Re: PR/44770 CVS commit: pkgsrc/devel/popt

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

The following reply was made to PR pkg/44770; it has been noted by GNATS.

From: Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
pkgsrc-bugs%NetBSD.org@localhost,
        Wolfgang.Stukenbrock%nagler-company.com@localhost
Subject: Re: PR/44770 CVS commit: pkgsrc/devel/popt
Date: Mon, 04 Apr 2011 15:24:06 +0200

 Hi,
 
 it is not nessesary to include config.h for theese sources.
 
 config.h is "normaly" included via system.h.
 
 The sources seems to assume that config.h is included prior poptint.h is 
 included by other files, because there are already some other 
 definitions from config.h that are used. So for poptint.h it is not 
 required to include config.h in this file (again).
 poptint.h is used in popt.c, poptconfig.c, popthelp.c and poptint.c.
 All theese sources include system.h before includeing poptint.h.
 
 lookup3.c is not compiled stand-alone, it is included in poptint.c and 
 there config.h is included via system.h before.
 
 OK, it is not the best style to do it this way, but we are in pkgsrc and 
 if the distribution does it this way, it makes no sence to change it for 
 pkgsrc.
 
 Best regards.
 
 W. Stukenbrock
 
 OBATA Akio wrote:
 
 > The following reply was made to PR pkg/44770; it has been noted by GNATS.
 > 
 > From: "OBATA Akio" <obache%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: PR/44770 CVS commit: pkgsrc/devel/popt
 > Date: Sat, 02 Apr 2011 11:02:04 +0900
 > 
 >  On Sat, 02 Apr 2011 06:30:07 +0900, Tim Zingelman 
 > <tez%netbsd.org@localhost> wrote:
 >  
 >  >  Log Message:
 >  >  Don't include stdint.h if it does not exist
 >  >  Fixes PR#44770
 >  
 >  I feel that "config.h" must be included additionally,
 >  or HAVE_STDINT_H will be never defined.
 >  
 > 
 
 
 -- 
 
 
 Dr. Nagler & Company GmbH
 Hauptstraße 9
 92253 Schnaittenbach
 
 Tel. +49 9622/71 97-42
 Fax +49 9622/71 97-50
 
 Wolfgang.Stukenbrock%nagler-company.com@localhost
 http://www.nagler-company.com
 
 
 Hauptsitz: Schnaittenbach
 Handelregister: Amberg HRB
 Gerichtsstand: Amberg
 Steuernummer: 201/118/51825
 USt.-ID-Nummer: DE 273143997
 Geschäftsführer: Dr. Martin Nagler, Dr. Dr. Karl-Kuno Kunze