Re: pkg/44786: pkgsrc 2010Q4 samba35 "somtimes" build with samba4 support

[Takahiro Kambe <taca%NetBSD.org@localhost>]

The following reply was made to PR pkg/44786; it has been noted by GNATS.

From: Takahiro Kambe <taca%NetBSD.org@localhost>
To: Wolfgang.Stukenbrock%nagler-company.com@localhost
Cc: gnats-bugs%NetBSD.org@localhost, taca%NetBSD.org@localhost
Subject: Re: pkg/44786: pkgsrc 2010Q4 samba35 "somtimes" build with samba4
 support
Date: Thu, 31 Mar 2011 18:27:24 +0900 (JST)

 In message <4D94440D.7010700%nagler-company.com@localhost>
        on Thu, 31 Mar 2011 11:06:21 +0200,
        Wolfgang Stukenbrock 
<Wolfgang.Stukenbrock%nagler-company.com@localhost> wrote:
 > Hi,
 Hi,
 
 > sorry no.
 I feel releived now since the build problem was not of my own. :-)
 
 > Back to my "samba4" options ...
 > 
 > If I set the enable option on the configure command line, the build
 > may/will fail for multible reasons:
 > - ads is not enabled - need to be checked in options.mk - no usable
 > - error indication from configure
 > - a missing "#include <limits.h>" in source4/heimdal/lib/roken/base64.c
 > - "some" missing RCSID definitions for several source files - may be a
 > - missing include for a heimdal-config.h file - there RCSID is defined
 > - during compilation "include/config.h" is not found
 > ... here I stop analyses - there seems to a lot of work to get it
 > compiling ....
 Yeah, I tried to handle <limits.h> and RCSID, too.
 
 > OK - sorry again - I missed to check if it would ever compile and it
 > doesn't.
 > The source4 tree is not setup correctly during configure phase.
 > I cannot say if the reason for this is a broken source in the samba
 > tar file or if it is related to the pkgsrc "patches" etc..
 I suspect samba4 support (merged build) would be testecd on Linux
 environment only.
 
 > I think, it would be better to disable merged build in all cases in
 > samba35.
 > This will speed up the configure script by bypassing lots of checks
 > and that part of the source will not compile at all (in pkgsrc-setup).
 Sure, and I was thinking so.
 
 > I recommend to change my patch to the following:
 > 
 > simply add --enable-merged-build=no to the configure options in
 > lang/samba35/Makefile and do not change lang/samba/options.mk as
 > mentioned in my previous mails.
 O.K.  I'll update in that direction.
 
 > sorry again - but I was in a hurry to get samba35 up and running on
 > Solaris 2.8, so I bypass a check of all setup varaints prior sending
 > the PR.
 Please don't worry.  Your report has absoluetely improved the
 configuration of samba packages.
 
 Best regards.
 
 -- 
 Takahiro Kambe <taca%NetBSD.org@localhost>/<taca%back-street.net@localhost>