pkg/44758: databases/openldap-client does not build with gcc-4.4

[ftigeot%wolfpond.org@localhost]

>Number:         44758
>Category:       pkg
>Synopsis:       databases/openldap-client does not build with gcc-4.4
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 22 22:30:00 +0000 2011
>Originator:     Francois Tigeot
>Release:        DragonFly 2.9
>Organization:
>Environment:
DragonFly akane.zefyris.com 2.9-DEVELOPMENT DragonFly 
v2.9.1.919.g53bd3-DEVELOPMENT #19: Sun Mar 20 23:05:11 CET 2011     
ftigeot%akane.zefyris.com@localhost:/usr/obj/usr/src/sys/X86_64_GENERIC_SMP  
x86_64
>Description:
databases/openldap-client fails to build when using gcc-4.4:

cc -I/usr/include -I../../include -I../../include   -I/usr/include  
-I/usr/include -c detach.c
--- version.c ---
--- detach.o ---
detach.c:131:7: error: missing binary operator before token "long"
*** [detach.o] Error code 1

bmake: stopped in 
/usr/pkgsrc/databases/openldap-client/work/openldap-2.4.23/libraries/liblutil

>How-To-Repeat:
Use a system with gcc-4.4 as its base compiler and try to build 
databases/openldap-client
>Fix:
The problem has been reported and fixed in the upstream development version:
http://www.openldap.org/its/index.cgi/?findid=6534

but we still need to add a small patch for the current version:

--- begin patch ---
$NetBSD$

--- libraries/liblutil/detach.c.orig   2011-01-04 23:50:10 +0000
+++ libraries/liblutil/detach.c
@@ -128,7 +128,7 @@ lutil_detach( int debug, int do_close )
 
 #ifdef HAVE_SETSID
                (void) setsid();
-#elif TIOCNOTTY
+#elif defined(TIOCNOTTY)
                if ( (sd = open( "/dev/tty", O_RDWR )) != -1 ) {
                        (void) ioctl( sd, TIOCNOTTY, NULL );
                        (void) close( sd );
--- end patch ---