pkg/44503: math/lp_solve uses the user shell to run a Bourne shell script

[ftigeot%wolfpond.org@localhost]

>Number:         44503
>Category:       pkg
>Synopsis:       math/lp_solve uses the user shell to run a Bourne shell script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 02 18:40:00 +0000 2011
>Originator:     Francois Tigeot
>Release:        DragonFly 2.9-DEVELOPMENT
>Organization:
>Environment:
DragonFly akane.zefyris.com 2.9-DEVELOPMENT DragonFly 
v2.9.1.543.gc6fd64-DEVELOPMENT #8: Thu Jan 27 12:15:51 CET 2011     
ftigeot%akane.zefyris.com@localhost:/usr/obj/usr/src/sys/X86_64_GENERIC_SMP  
x86_64
>Description:
math/lp_solve uses the user shell to run a Bourne shell script

It runs fine as long as the user uses a Bourne or Bourne-compatible shell such 
as sh or bash, but fails if this condition is not met:

[user shell is /bin/csh]

# bmake
[...]
===> Building for lp_solve-5.5.2.0
=> Substituting "dl" in lp_solve/ccc lpsolve55/ccc demo/ccc
cd /pkgsrc/math/lp_solve/work/lp_solve_5.5/lp_solve && /bin/csh ccc
src=../lp_MDO.c ../shared/commonlib.c ../colamd/colamd.c ../shared/mmio.c 
../shared/myblas.c ../ini.c ../fortify.c ../lp_rlp.c ../lp_crash.c 
../bfp/bfp_LUSOL/lp_LUSOL.c ../bfp/bfp_LUSOL/LUSOL/lusol.c ../lp_Hash.c 
../lp_lib.c ../lp_wlp.c ../lp_matrix.c ../lp_mipbb.c ../lp_MPS.c ../lp_params.c 
../lp_presolve.c ../lp_price.c ../lp_pricePSE.c ../lp_report.c ../lp_scale.c 
../lp_simplex.c lp_solve.c ../lp_SOS.c ../lp_utils.c ../yacc_read.c: Command 
not found.
c=cc: Command not found.
Invalid null command.
*** Error code 1


>How-To-Repeat:
Use /bin/csh as your shell and try to install math/lp_solve
>Fix:
Apply this patch to math/lp_solve/Makefile

--- Makefile.orig       2010-10-16 15:35:08 +0000
+++ Makefile    2011-02-02 18:19:50 +0000
@@ -37,9 +37,9 @@
 INSTALLATION_DIRS=     bin include/lpsolve lib
 
 do-build:
-       cd ${WRKSRC}/lp_solve && ${SHELL} ccc
-       cd ${WRKSRC}/lpsolve55 && ${SHELL} ccc
-       cd ${WRKSRC}/demo && ${SHELL} ccc
+       cd ${WRKSRC}/lp_solve && ${SH} ccc
+       cd ${WRKSRC}/lpsolve55 && ${SH} ccc
+       cd ${WRKSRC}/demo && ${SH} ccc
 
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/lp_solve/bin/${LPSOLVE_ARCH}/lp_solve \