pkg/43985: x11/xkeyboard-config distfile checksum error (& empty copy on f.n.o)

[kre%munnari.OZ.AU@localhost]

>Number:         43985
>Category:       pkg
>Synopsis:       x11/xkeyboard-config distfile checksum error (& empty copy on 
>f.n.o)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 19 11:45:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 5.1_RC3   (pkgsrc current 2010-10-19)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_RC3 NetBSD 5.1_RC3 (JADE-1.12-20100614) 
#2: Mon Jun 14 08:35:26 ICT 2010 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5.1/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        The distfile (xkeyboard-config-2.0.tar.bz2) on the
        master site (http://people.freedesktop.org/~svu/) for
        x11/xkeyboard-config does not match (size or checksum) with
        what pkgsrc's distinfo file expects.

        Furthermore, there's an empty copy of the file (apparently)
        on f.n.o

>How-To-Repeat:
        Move aside any existing copy of xkeyboard-config-2.0.tar.bz2

        cd ..../pkgsrc/x11/xkeyboard-config
        make checksum

        Expect to see ...

=> Total size: 656757 bytes
Requesting http://people.freedesktop.org/~svu/xkeyboard-config-2.0.tar.bz2
100% |***********************************|   631 KiB   95.86 KiB/s    00:00 ETA
646689 bytes retrieved in 00:06 (95.85 KiB/s)
checksum: Checksum SHA1 mismatch for xkeyboard-config-2.0.tar.bz2

        Note that the file size fetched is not the size expected,
        and (naturally) the checksum fails to match

        Later ...

Trying 2001:4f8:3:7:230:48ff:fec6:9aaa:21 ...
Connected to ftp.netbsd.org.
220 ftp.NetBSD.org FTP server (NetBSD-ftpd 20100320) ready.
331 Guest login ok, type your name as password.
  [.... etc, very long banner deleted... ]
local: xkeyboard-config-2.0.tar.bz2 remote: xkeyboard-config-2.0.tar.bz2
229 Entering Extended Passive Mode (|||61843|)
150 Opening BINARY mode data connection for 'xkeyboard-config-2.0.tar.bz2' (0 
bytes).
     0        0.00 KiB/s 
226 Transfer complete.

        Needless to say, the checksum of that empty file doesn't
        match either...

>Fix:
        Find out what changed between what is in the distfile on the
        master site now, and what was expected when the package was upgraded.
        If the changes are harmless, add a DIST_SUBDIR, update the
        distinfo file, and we're done (perhaps remove the empty file
        from f.n.o - it will be wasting an inode...)

        If the master site copy is not safe, then put a copy of the
        good distfile on f.n.o ad comment out the master site from the
        Makefile (no point having people fetch nonsense for no good reason.)

        Perhaps bitch at the upstream maintainer, though for exactly
        what will depend upon what is discovered when the original,
        and current, distfile contents are compared (I can't do that,
        I don't have the original).

        It would also be worth working out what's causing these empty
        files to be left on f.n.o when this checksum problem occurs
        (twice observed in the past 2 days - see also PR 43984)
        f.n.o should either have no file at all, or a copy of the
        (or some version of the) master site distfile, not something
        different.   The empty file is "something different".  Something
        is broken...