Re: pkg/43547: [PATCH] (graphics/netpbm) Darwin has /usr/lib/libz.* separated

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/43547; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/43547: [PATCH] (graphics/netpbm) Darwin has
        /usr/lib/libz.* separated
Date: Thu, 1 Jul 2010 20:16:27 +0000

 On Thu, Jul 01, 2010 at 03:00:00PM +0000, makoto%ki.nu@localhost wrote:
  > --- graphics/netpbm/Makefile        13 Jun 2010 22:44:39 -0000      1.166
  > +++ graphics/netpbm/Makefile        1 Jul 2010 14:45:04 -0000
  > @@ -67,6 +67,10 @@
  >  CPPFLAGS+= -DSGI_IDO_CC
  >  .endif
  >  
  > +.if ${OPSYS} == "Darwin"
  > +LDFLAGS+=      -lz
  > +.endif
  > +
  >  .include "../../graphics/jasper/buildlink3.mk"
  >  .include "../../graphics/png/buildlink3.mk"
  >  .include "../../graphics/tiff/buildlink3.mk"
 
 Should at a minimum be LIBS, not LDFLAGS. However, it looks like the
 problem is that we set PNGLIB like this:
 
    PNGLIB = $(BUILDLINK_DIR)/lib/libpng$(PNGVER).so
 
 and it seems like it would be better to use libpng-config, as follows:
 
    PNGLIB = $(shell libpng-config --libs)
 
 and let the buildlink wrappers take care of making sure the right lib
 gets pulled in. But I may be missing some buildlink subtlety.
 
 Can you check if just running
 
    % libpng-config --libs
 
 on your system includes -lz as well as -lpng14?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost