pkg/43464: graphics/netpbm Darwin 8 PLIST issues

[ef%math.uni-bonn.de@localhost]

>Number:         43464
>Category:       pkg
>Synopsis:       graphics/netpbm Darwin 8 PLIST issues
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 12 21:45:00 +0000 2010
>Originator:     Edgar Fuß
>Release:        pkgsrc-2010Q1
>Organization:
Mathematisches Institut der Uni Bonn
>Environment:
Darwin XXX 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; 
root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
        graphic/netpbm's Makefile doesn't build Fiasco:
        # Fiasco fails to compile on Darwin-8.x.
        .if !empty(MACHINE_PLATFORM:MDarwin-8.*-*)
        MAKE_ENV+=      BUILD_FIASCO=N
        .endif
        yet the PLIST unconditionally contains fiascotopnm etc.

>How-To-Repeat:
        cd graphics/fiasco; bmake package
>Fix:
        I love how the pkgsrc infrastucture makes this easy as nothing:
        
        --- Makefile.orig       2010-06-06 16:15:40.000000000 +0200
        +++ Makefile    2010-06-12 23:35:52.000000000 +0200
        @@ -49,9 +49,12 @@
         
         .include "../../mk/bsd.prefs.mk"
         
        +PLIST_VARS+=   fiasco
         # Fiasco fails to compile on Darwin-8.x.
         .if !empty(MACHINE_PLATFORM:MDarwin-8.*-*)
         MAKE_ENV+=     BUILD_FIASCO=N
        +.else
        +PLIST.fiasco=  yes
         .endif
         
         .if ${OPSYS} == "Darwin"
        --- PLIST.orig  2010-02-19 19:25:44.000000000 +0100
        +++ PLIST       2010-06-12 23:36:31.000000000 +0200
        @@ -13,7 +13,7 @@
         bin/doc.url
         bin/escp2topbm
         bin/eyuvtoppm
        -bin/fiascotopnm
        +${PLIST.fiasco}bin/fiascotopnm
         bin/fitstopnm
         bin/fstopgm
         bin/g3topbm
        @@ -209,7 +209,7 @@
         bin/pnmstitch
         bin/pnmtile
         bin/pnmtoddif
        -bin/pnmtofiasco
        +${PLIST.fiasco}bin/pnmtofiasco
         bin/pnmtofits
         bin/pnmtojbig
         bin/pnmtojpeg
        @@ -355,7 +355,7 @@
         man/man1/ddbugtopbm.1
         man/man1/escp2topbm.1
         man/man1/eyuvtoppm.1
        -man/man1/fiascotopnm.1
        +${PLIST.fiasco}man/man1/fiascotopnm.1
         man/man1/fitstopnm.1
         man/man1/fstopgm.1
         man/man1/g3topbm.1
        @@ -540,7 +540,7 @@
         man/man1/pnmstitch.1
         man/man1/pnmtile.1
         man/man1/pnmtoddif.1
        -man/man1/pnmtofiasco.1
        +${PLIST.fiasco}man/man1/pnmtofiasco.1
         man/man1/pnmtojbig.1
         man/man1/pnmtojpeg.1
         man/man1/pnmtopalm.1