Re: pkg/42825: x11/kdelibs4 fails to compile (NetBSD 4.0 / i386)

[Mark Davies <mark%ecs.vuw.ac.nz@localhost>]

The following reply was made to PR pkg/42825; it has been noted by GNATS.

From: Mark Davies <mark%ecs.vuw.ac.nz@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/42825: x11/kdelibs4 fails to compile (NetBSD 4.0 / i386)
Date: Sun, 6 Jun 2010 16:57:09 +1200

 On Wednesday 17 February 2010 03:25:00 you wrote:
 > >Fix:
 >      Something needs to include <sys/mman.h> I assume.
 
 The code has:
 
 #if HAVE_MADVISE
 #include <sys/mman.h> // This #include was checked when looking for 
 posix_madvise
 #endif
 
 and HAVE_MADVISE is set if posix_madvise() exists, which it wont for 4.0.
 
 
 I think the HAVE_MADVISE should be changed to HAVE_MMAP, which the code 
 also uses.  Are there any OS's (that pkgsrc cares about) that have mmap() 
 but not <sys/mman.h>?   I presume not.
 
 cheers
 mark