pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/43325: [PATCH] textproc/namazu is not really WAKATI friendly, internal make check fails



The following reply was made to PR pkg/43325; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/43325: [PATCH] textproc/namazu is not really WAKATI
        friendly, internal make check fails
Date: Mon, 31 May 2010 19:36:47 +0000

 On Fri, May 21, 2010 at 02:05:04AM +0000, Makoto Fujiwara wrote:
  >  It would be nice to have some note on 'make check' in MESSAGES.
  >  (But MESSAGES is both for make install and for pkg_add, and the 
  >  latter may not apply for this note, sorry).
  >  
  >  Index: textproc/namazu/MESSAGE
  > [...]
  >  +8. If you do 'make check' with LANG=ja after source install (in its 
working
  >  +   directory), modify 'pl/conf.pl' at $WAKATI= line for your wanted
  >  +   module before that.
 
 Indeed, MESSAGE is not really the right place for that note; also,
 pkgsrc isn't really meant to support going and running things by hand
 inside the work directory. (Sometimes correct behavior depends on
 settings passed through from the package makefile.)
 
 Maybe the right way to approach this is to add rules to the pkgsrc
 makefile for running the tests from there? The substitution could be
 automated then.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost
 


Home | Main Index | Thread Index | Old Index