pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/43325: [PATCH] textproc/namazu is not really WAKATI friendly, internal make check fails



The following reply was made to PR pkg/43325; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/43325: [PATCH] textproc/namazu is not really WAKATI friendly,
 internal make check fails
Date: Thu, 20 May 2010 11:23:16 +0900

 On Thu, 20 May 2010 08:55:03 +0900, Makoto Fujiwara <makoto%ki.nu@localhost> 
wrote:
 
 >  (1) I would like to 'make check' before     install. With some environment,
 >    I said 'some' but it may be with some large audience, make check fails
 >    with existing setup. ( LANG=ja.. environment)
 
 You can edit 'pl/config.pl' and change $WAKATI for your wanted module before 
test,
 and you can test with all patterns of WAKATI module.
 
 >  (2) I saw some discussions (just question and answers)  on also 'make check'
 >      was failing with the same reason  at  namazu-dev-ja mailing list,
 >     (in Japanese, sorry)  staring at:
 >     http://www.namazu.org/pipermail/namazu-devel-ja/2009-February/001771.html
 
 I feel it is upstream issue.
 If any of wakati module is not found WAKATI=$none is set in config.pl.
 but $none is not defined anywhere.
 
 >  (3) My patch does not break existing setup as default is non-wakati. It only
 >      affects when the options are setup ( say in /etc/mk.conf)
 >      This means we provide user's choise WITH or WITHOUT wakati
 
 No.
 Namazu's configure script pick up WAKATI modules and commands as it can 
possible.
 As your patch, even if any of WAKATI modules are not selected by pkg-option,
 if any of kakasi, chasen, mecab perl modules or those commands are found,
 they are set in default config.pl.
 It means that default configuration file is depend on the situation of build 
machine.
 Incidentally, if you set only mecab option, but you have kakasi command,
 kakasi command will be selected as default WAKATI because its selection order 
for default
 WAKATI is hard coded as kakasi > chasen > mecab.
 


Home | Main Index | Thread Index | Old Index