pkg/43175: libarchive-2.8.3 fails to build due xattr missing

[tuxillo%leaf.dragonflybsd.org@localhost]

>Number:         43175
>Category:       pkg
>Synopsis:       libarchive-2.8.3 fails to build due xattr missing
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          support
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 18 19:45:00 +0000 2010
>Originator:     Antonio Huete Jimenez
>Release:        N/A
>Organization:
DragonFlyBSD
>Environment:
DragonFly smash 2.7-DEVELOPMENT DragonFly v2.7.1.11.g845f5-DEVELOPMENT #8: Sun 
Apr 18 20:08:35 CEST 2010     
antonioh@smash:/usr/obj/home/source/dfbsd/sys/GENERIC_SMP  i386
>Description:
Hi,

libarchive-2.8.3 build fails due missing xattr in DFBSD:

--- libarchive/archive_write_disk.lo ---
depbase=`echo libarchive/archive_write_disk.lo | sed 
's|[^/]*$|.deps/&|;s|\.lo$||'`; /bin/sh ./libtool --tag=CC    --mode=compile cc 
-DHAVE_CONFIG_H -I.    -I/usr/include  -O2 -O -g -I/usr/include -MT 
libarchive/archive_write_disk.lo -MD -MP -MF $depbase.Tpo -c -o 
libarchive/archive_write_disk.lo libarchive/archive_write_disk.c && mv -f 
$depbase.Tpo $depbase.Plo
libtool: compile:  cc -DHAVE_CONFIG_H -I. -O2 -O -g -MT 
libarchive/archive_write_disk.lo -MD -MP -MF 
libarchive/.deps/archive_write_disk.Tpo -c libarchive/archive_write_disk.c  
-fPIC -DPIC -o libarchive/.libs/archive_write_disk.o
libarchive/archive_write_disk.c: In function 'set_xattrs':
libarchive/archive_write_disk.c:2504: error: 'EXTATTR_NAMESPACE_USER' 
undeclared (first use in this function)
libarchive/archive_write_disk.c:2504: error: (Each undeclared identifier is 
reported only once
libarchive/archive_write_disk.c:2504: error: for each function it appears in.)
libarchive/archive_write_disk.c:2523: warning: passing argument 2 of 
'extattr_set_file' makes pointer from integer without a cast
libarchive/archive_write_disk.c:2523: warning: passing argument 3 of 
'extattr_set_file' from incompatible pointer type
libarchive/archive_write_disk.c:2523: warning: passing argument 4 of 
'extattr_set_file' makes integer from pointer without a cast
libarchive/archive_write_disk.c:2523: error: too many arguments to function 
'extattr_set_file'
*** [libarchive/archive_write_disk.lo] Error code 1
--- libarchive/archive_write.lo ---
libtool: compile:  cc -DHAVE_CONFIG_H -I. -O2 -O -g -MT 
libarchive/archive_write.lo -MD -MP -MF libarchive/.deps/archive_write.Tpo -c 
libarchive/archive_write.c -o libarchive/archive_write.o >/dev/null 2>&1
1 error

bmake: stopped in /usr/pkgsrc/archivers/libarchive/work/libarchive-2.8.3
*** [all] Error code 2
1 error

bmake: stopped in /usr/pkgsrc/archivers/libarchive/work/libarchive-2.8.3
*** Error code 2

Stop.
bmake: stopped in /usr/pkgsrc/archivers/libarchive
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/archivers/libarchive

>How-To-Repeat:
Just try to build libarchive from pkgsrc -current in DFBSD.
>Fix:
See below the patch courtesy of Alexander Polakov:

diff --git a/archivers/libarchive/Makefile b/archivers/libarchive/Makefile
index 4149e67..8214391 100644
--- a/archivers/libarchive/Makefile
+++ b/archivers/libarchive/Makefile
@@ -18,6 +18,13 @@ USE_LIBTOOL= yes
 CONFIGURE_ARGS+=       --disable-bsdtar --without-expat --without-xml2 \
                        --disable-bsdcpio

+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "DragonFly"
+CONFIGURE_ARGS+=        --disable-xattr
+.endif
+
+
 do-extract:
        ${CP} -r ${FILESDIR} ${WRKSRC}