pkg/43087: flash audio out of sync with multimedia/libflashsupport

[Johannes.Hofmann%gmx.de@localhost]

>Number:         43087
>Category:       pkg
>Synopsis:       flash audio out of sync with multimedia/libflashsupport
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 31 09:35:00 +0000 2010
>Originator:     Johannes Hofmann
>Release:        DragonFly
>Organization:
>Environment:
DragonFly blob.baaderstrasse.com 2.5.1-DEVELOPMENT DragonFly 
v2.5.1.1083.g69adb-DEVELOPMENT #20: Sun Mar 28 20:30:24 CEST 2010     
hofmann%blob.baaderstrasse.com@localhost:/hammer/usr/obj/hammer/usr/src/sys/T42 
 i386
>Description:
Video and audio are not in sync when playing flash videos via linux emulation.
The problem is a bug in the OSS interface of multimedia/libflashsupport.



>How-To-Repeat:
Play a youtube video with multimedia/libflashsupport installed and check
for video/audio synchronization.
>Fix:
The following patch fixes the issue, however multimedia/libflashsupport
currently extracts a Linux binary from some rpm, so it is unclear (to me) where 
or how to apply this patch.

--- flashsupport.c.orig 2010-03-31 11:27:45 +0200
+++ flashsupport.c      2010-03-31 11:33:59 +0200
@@ -775,7 +775,7 @@
        struct SoundOutput_Instance *instance = (struct SoundOutput_Instance 
*)ptr;
        if ( instance->oss_fd ) {
                int value = 0;
-               if ( ( value = 
ioctl(instance->oss_fd,SNDCTL_DSP_GETODELAY,&value) ) == 0 ) {
+               if ( ioctl(instance->oss_fd,SNDCTL_DSP_GETODELAY,&value) != -1 
) {
                        return value / 4;
                }
                return 0;