pkg/43020: devel/scmgit-base: _XOPEN_SOURCE problem on DragonFly

[y0netan1%dragonflybsd.org@localhost]

>Number:         43020
>Category:       pkg
>Synopsis:       devel/scmgit-base: _XOPEN_SOURCE problem on DragonFly
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 20 11:05:00 +0000 2010
>Originator:     YONETANI Tomokazu
>Release:        
>Organization:
>Environment:
DragonFly atom64 2.5.1-DEVELOPMENT DragonFly v2.5.1.995.g8af66-DEVELOPMENT #0: 
Wed Mar 17 07:02:46 JST 2010     y0netan1@atom64:/usr/obj/ATOM64  x86_64
>Description:
The current git source code doesn't know about DragonFly BSD, and it
defines _XOPEN_SOURCE to 600 for OSes unknown to it.
On recent DragonFly BSD, when _XOPEN_SOURCE is set to 600, some
 (POSIX-ly?) non-standard function prototype declarations are hidden
from the programs when GCC is operating in C99 mode (-std=gnu99).
With those symbols undefined (but not for configure script), the return
type of thems are assumed to be int.  It seems to be harmless on architectures
where sizeof(int)==sizeof(void *), but it's not the case on x86_64.
This only happens on DragonFly 2.3-DEVELOPMENTor later, and on earlier
versions those functions are exposed even with_XOPEN_SOURCE set, so it
wasn't a problem.  Same thing happened to FreeBSD, and it's been resolved
in git source by not defining it for defined(__FreeBSD__).

>How-To-Repeat:
Try building devel/scmgit-base on DragonFly 2.4-RELEASE or later and see
the warnings.  Note that this won't reproduce when you try to compile it
directly in ${WRKSRC}, as it's the pkgsrc wrapper script which adds the option
-std=gnu99 to GCC's command line.
>Fix:
Apply this patch on top of pkgsrc source code.  This shouldn't affect earlier 
releases of
DragonFly BSD, or any other OSes.

begin-base64 644 dfly-scmgit-base.patch.gz
H4sIAFSfpEsCA61UbW/bNhD+PP2KG1oUSWXJJEVSkrEO8WoXC5Y6wZwAGTBA4MvR1iZLgaWsy379
SDvZZqdNv4wfCL7c89zxnjuabrOpByAyp7pE1MIwangpqFVW85yh4wXLdYFWEot5NL0f1t12Ar9c
LubX08U5XHeb7nf11z1890BaHFRLz+xWrbrWNQ+6t2m3XX0fzdSAEwBYqgE+qi0wAlROmJiQwq8p
gZiUhESRN4GbtscBqtvLq/miWl7e/Px+Dq7bwmzH+qF5SKPI1s5Bkqx85Gps8Q9sxr3Z+G2iVY9j
W/dD3boO9AuXUd1a/BNMqY2hJk1Lwjl1BVBCJOdRkiQvckdxHL/Mf3YGCSWjDGI/c/Db5Y9TCid3
ajDrRLlTeAeoiDKCZJRknJUuY5ZJbTkzWa5KtEJmzlGf/ugQuwpYwgtbcu7jLpDT3ClNqMmQYIES
C2pL6zLtlDnCrgPWq6lFRjglpZPc5YRyqRhjTqKmNtRBYa18hq0DVkgtM8vzkihKnfAAVtBCKivQ
WUu1cZQwxzCKD7C/BazSkitdEkYkI6rM8sCQ+7w7x2VuNGNcFdaYrym848R+/MT9WSWOjaIWP4Gr
G4RNZ/FJ6H0ZkP1IU5LzXKDd6R84x+1903xR7Gcuguhk5Auajqjwmkfx6wUOPyxnr6N4iwbb4d9C
hrXq4W7b6QY38Kke1odV/04SMoKh69IojuIQT3Bruo13ltwPdZOufXfVq29CByWEJZQCKSaUTQR9
bKg4xP0M9QjIkn0bEt+G4gkQ4hdilEPs52L3AHgF2PS4W1h0dYtH3SkCMFi1XjUf6Stsagff7m3t
SVVNr64u5lV1Cm/e/Pf4wxbRZyZcHN3cLC/eP7P/WN0szm8PD/tVfepf+b96/NUTwm583fcRyz/S
eqqQks+my8sK47ewamptGKjWwvT8FkSaXUCLaEM6R3B5h62PdHfS7yDhD1xW58uLxU8np/B2/CX+
an57PV/M5jOgwc0Bdw/Duu4fwXu5/gZsAiyPAQYAAA==
====