Re: PR/42274 CVS commit: pkgsrc/x11/xorg-cf-files

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/42274; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/42274 CVS commit: pkgsrc/x11/xorg-cf-files
Date: Wed, 17 Mar 2010 16:16:24 +0100

 --VbJkn9YxBvnuCH5J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Wed, Mar 17, 2010 at 02:40:04PM +0000, Thomas Klausner wrote:
 > The following reply was made to PR pkg/42274; it has been noted by GNATS.
 > 
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
 > Cc: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > Subject: Re: PR/42274 CVS commit: pkgsrc/x11/xorg-cf-files
 > Date: Wed, 17 Mar 2010 15:34:26 +0100
 > 
 >  On Wed, Mar 17, 2010 at 02:10:07PM +0000, Joerg Sonnenberger wrote:
 >  >  Should have objected earlier, but the files are setup for dealing with
 >  >  normal make, not with gmake. As such I disagree with this change.
 >  >  The IMAKE_MAKE default should be restricted to X11_TYPE=native.
 >  
 >  Do you have a diff? I don't understand your explanation well enough to
 >  derive one...
 
 Attached.
 
 Joerg
 
 --VbJkn9YxBvnuCH5J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="imake-make.diff"
 
 Index: tools/make.mk
 ===================================================================
 RCS file: /home/joerg/repo/netbsd/pkgsrc/mk/tools/make.mk,v
 retrieving revision 1.13
 diff -u -p -r1.13 make.mk
 --- tools/make.mk      17 Jul 2005 21:36:24 -0000      1.13
 +++ tools/make.mk      17 Mar 2010 15:15:49 -0000
 @@ -49,7 +49,7 @@
  # Define MAKE_PROGRAM to be the "make" used to build the package.
  .if !empty(_USE_TOOLS:Mgmake)
  MAKE_PROGRAM=         ${GMAKE}
 -.elif !empty(_USE_TOOLS:Mimake) && defined(IMAKE_MAKE)
 +.elif !empty(_USE_TOOLS:Mimake) && defined(IMAKE_MAKE) && ${X11_TYPE} == 
"native"
  MAKE_PROGRAM=         ${IMAKE_MAKE}
  .else
  MAKE_PROGRAM=         ${MAKE}
 
 --VbJkn9YxBvnuCH5J--