Re: pkg/42102 - Adjusting __weak_alias in libnbcompat

[David Brownlee <abs%netbsd.org@localhost>]

The following reply was made to PR pkg/42102; it has been noted by GNATS.

From: David Brownlee <abs%netbsd.org@localhost>
To: joerg%netbsd.org@localhost, gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost, 
        kordex%gmail.com@localhost
Subject: Re: pkg/42102 - Adjusting __weak_alias in libnbcompat
Date: Thu, 31 Dec 2009 14:00:23 +0000

 Joerg - would you be happy with the '#ifdef __weak_alias'  being '#if
 defined(__NetBSD__) && defined(__weak_alias)', or do we need to handle
 more OS variants?
 
 
 2009/12/31 OBATA Akio <obache%netbsd.org@localhost>:
 > The following reply was made to PR pkg/42102; it has been noted by GNATS.
 >
 > From: "OBATA Akio" <obache%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: pkg/42102 (pkgsrc fails bootstraping on openbsd amd64)
 > Date: Thu, 31 Dec 2009 11:39:05 +0900
 >
 > =C2=A0On Thu, 31 Dec 2009 05:35:11 +0900, <abs%netbsd.org@localhost> wrote:
 >
 > =C2=A0> I wonder if this is related to the #ifdef __weak_alias section or=
  an existing
 > =C2=A0> definition of DB...
 > =C2=A0> As a quick test could you try editing pkgsrc/pkgtools/libnbcompat=
 /files/db/db/db.c
 > =C2=A0> and remove the following section around line 48
 > =C2=A0>
 > =C2=A0> #ifdef __weak_alias
 > =C2=A0> __weak_alias(dbopen,_dbopen)
 > =C2=A0> #endif
 > =C2=A0>
 > =C2=A0> then try rerunning bootstrap?
 >
 > =C2=A0__weak_alias also in db/mpool/mpool.c.
 >
 > =C2=A0As far as I know, I came from a bug of __weak_alias on OpenBSD
 > =C2=A0(or you could say that the spec of __weak_alias on OpenBSD is
 > =C2=A0differ than one on NetBSD).
 >
 > =C2=A0I think that macros prefixed with "__" are not portable, should not=
  be used in
 > =C2=A0applications/libraries, or at least, __NetBSD__ macro should be che=
 cked first.
 >
 >