Re: pkg/42396 (sysutils/dbus does not compile on Solaris with GCC 3)

[Tim Zingelman <zingelman%gmail.com@localhost>]

On Tue, Dec 1, 2009 at 7:00 AM,  <asau%netbsd.org@localhost> wrote:
> Synopsis: sysutils/dbus does not compile on Solaris with GCC 3
>
> Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
> Responsible-Changed-By: asau%NetBSD.org@localhost
> Responsible-Changed-When: Tue, 01 Dec 2009 13:00:25 +0000
> Responsible-Changed-Why:
> Solaris problem.

Actually a dbus/gcc problem.

Release notes here
http://lists.freedesktop.org/archives/dbus/2009-July/011574.html
for dbus 1.2.16 indicate this is fixed in that version... pkgsrc is
however using the 'permissive' branch which does not have this fixed.

According to this email:
http://lists.freedesktop.org/archives/dbus/2008-December/010769.html
the hope was to eliminate the permissive branch, but I'm not a dbus
user so I don't know the implications.

So, here is an update to patch-ac that merges the fix from 1.2.16...
seems to build for me with this...

Index: distinfo
===================================================================
RCS file: /usr/cvs/pkgsrc/sysutils/dbus/distinfo,v
retrieving revision 1.34
diff -w -u -b -r1.34 distinfo
--- distinfo    23 Nov 2009 19:10:46 -0000      1.34
+++ distinfo    1 Dec 2009 19:26:19 -0000
@@ -5,7 +5,7 @@
 Size (dbus-1.2.4.6permissive.tar.gz) = 1575270 bytes
 SHA1 (patch-aa) = fd7cc2e11e15e13885e882e8de51e17af8a63d70
 SHA1 (patch-ab) = b2761914edfe2c7666c5412abf79c5d7b87a2006
-SHA1 (patch-ac) = afec419973f339e846dc109866148529f80998b3
+SHA1 (patch-ac) = 63aab0ffac02a9cb85a80e31bbb1234534db378b
 SHA1 (patch-ag) = 999071b782982c12329025ea8e393bfed940b654
 SHA1 (patch-ai) = a45bd8d29955e9c14a4d8b3f44b42242d70c1cd8
 SHA1 (patch-ak) = 56c0a917e770b8d6ffc37ec7ab8beb631dd8ef72
Index: patches/patch-ac
===================================================================
RCS file: /usr/cvs/pkgsrc/sysutils/dbus/patches/patch-ac,v
retrieving revision 1.8
diff -w -u -b -r1.8 patch-ac
--- patches/patch-ac    13 Jun 2008 11:28:35 -0000      1.8
+++ patches/patch-ac    1 Dec 2009 19:26:04 -0000
@@ -1,8 +1,8 @@
 $NetBSD$

---- configure.orig     2008-04-04 14:23:44.000000000 -0400
-+++ configure
-@@ -5996,6 +5996,224 @@ esac
+--- configure.orig     2009-05-06 12:35:38.000000000 -0500
++++ configure  2009-12-01 13:23:46.338973100 -0600
+@@ -6110,6 +6110,224 @@

  need_locks="$enable_libtool_lock"

@@ -227,3 +227,15 @@

  # On IRIX 5.3, sys/types and inttypes.h are conflicting.

+@@ -20958,7 +21176,10 @@
+   esac
+   case " $CFLAGS " in
+   *[\ \       ]-Wno-pointer-sign[\ \  ]*) ;;
+-  *) CFLAGS="$CFLAGS -Wno-pointer-sign" ;;
++  *) if cc_supports_flag -Wno-pointer-sign; then
++      CFLAGS="$CFLAGS -Wno-pointer-sign"
++     fi
++     ;;
+   esac
+
+   # http://bugs.freedesktop.org/show_bug.cgi?id=19195