pkg/42232: graphics/eog missing gnome dependencies (+FIX (part fix?))

[kre%munnari.OZ.AU@localhost]

>Number:         42232
>Category:       pkg
>Synopsis:       graphics/eog missing gnome dependencies (+FIX (part fix?))
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 26 10:40:00 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386  pkgsrc current 2009-10-26
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        graphics/gnome fails to build (fails to configure)
        due to missing gnome dependencies.

        Further, it seems to have a hodden dependency upon
        pygtk, which while it doens't stop the build would,
        I assume, cause different packages to be built depending
        upon whether or not pygtk is installed or not.

        And last, a binary package built (after correcting the
        first problem) installs just fine on a system which has
        the earlier version of gnome on it, without complaining
        about needing anything newer, or anything else upgraded,
        but (unsurprisingly) dumps core when executed.
        (This one is, i think, a general pkgsrc problem, not
        specificlaly with eog, and I also suspect is fairly well known).

>How-To-Repeat:
        I used pkg_comp with libkver and NetBSD 4.0 sets installed,
        except x* sets, I use pkgsrc modular xorg instead - I doubt any
        of that is relevant to this problem, except that by using pkg_comp
        I end up starting with a very clean environment (essentially nothing
        installed) except what the package demands as a dependency.

        In that environment, upon attempting to build graphics/eog (2.28.1)
        I see ...

===> Overriding tools for eog-2.28.1
===> Extracting for eog-2.28.1
===> Patching for eog-2.28.1
===> Creating toolchain wrappers for eog-2.28.1
ERROR: libglade>=2.3.6 is not installed; can't buildlink files.
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/graphics/eog

        After fixing that (see below), the same thing happens
        except for libgnome instead of libglade, and then after
        fixing that, same again, except this time for libgnomeui

        After fixing all of those, the binary package builds fine,
        but along the way says ...

checking for a Python interpreter with version >= 2.3... python2.5
checking for python2.5... /usr/pkg/bin/python2.5
checking for python2.5 version... 2.5
checking for python2.5 platform... netbsd4
checking for python2.5 script directory... ${prefix}/lib/python2.5/site-packages
checking for python2.5 extension module directory... 
${exec_prefix}/lib/python2.5/site-packages
checking for PYGTK... no
configure: WARNING: No package 'pygobject-2.0' found
No package 'pygtk-2.0' found
configure: WARNING: Disabling python support
configure: creating ./config.status

        which to me suggests that had pygtk-2.0 been installed,
        python support would not have been disabled, and a different
        binary package would have been created.

        I took the binary package to a system where I had installed all
        new packages from stuff I compiled up to October 4 (so has
        gnome stuff that is 2.26.* on it) - I took just this one
        binary package, pkg_deleted the old eog (I kind of like to
        have it installed, just in case it is ever useful, but having
        it missing for months would probably not be noticed) and attempted
        to pkg_add the one I had just built.   I was expecting that to
        fail, so I could say in this PR, something like "I was unable to
        test the package I built as that would have required updating
        all gnome applications which I cannot do right now" - but no
        such luck, pkg_add didn't mind adding it, so now I have a 2.28
        version eog installed (with no complaints at all, except
        pkgsrc's meaningless one about the OS version ot being the same,
        which I get for everything) when everything else gnomish is
        from the previous 2.26 vintage (of course in the pkg_comp
        arena used to build this, there were all 2.28 gnome packages
        installed).

        The eog just installed dumps core.   That's so unsurprising that
        it isn't even worth looking at a stack trace to see what happened.

>Fix:
        The patch below is my method of at making eog compile.
        Whether this is correct, and even if correct, whether it
        is the right way to fix it I leave for someone more qualified to
        judge...

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/graphics/eog/Makefile,v
retrieving revision 1.52
diff -u -r1.52 Makefile
--- Makefile    21 Oct 2009 17:56:37 -0000      1.52
+++ Makefile    26 Oct 2009 09:57:07 -0000
@@ -37,6 +37,9 @@
 .include "../../graphics/lcms/buildlink3.mk"
 BUILDLINK_API_DEPENDS.libexif+=        libexif>=0.6.12
 .include "../../graphics/libexif/buildlink3.mk"
+.include "../../devel/libglade/buildlink3.mk"
+.include "../../devel/libgnome/buildlink3.mk"
+.include "../../devel/libgnomeui/buildlink3.mk"
 .include "../../sysutils/desktop-file-utils/desktopdb.mk"
 BUILDLINK_API_DEPENDS.shared-mime-info+= shared-mime-info>=0.20
 .include "../../databases/shared-mime-info/buildlink3.mk"