pkg/42064: freeradius2 'make package' and PERL inclusion

[bsd-xen%roguewrt.org@localhost]

>Number:         42064
>Category:       pkg
>Synopsis:       'make package' produces errors and no PERL module available
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 15 06:00:01 +0000 2009
>Originator:     Sarton O'Brien
>Release:        NetBSD 5.99.15
>Organization:
        
>Environment:
        
        
System: NetBSD sammy.internal 5.99.15 NetBSD 5.99.15 (XEN3_DOMU) #1: Thu Jul 30 
14:41:07 EST 2009 
root%spike.internal@localhost:/usr/obj/sys/arch/amd64/compile/XEN3_DOMU amd64
Architecture: x86_64
Machine: amd64
>Description:

When issuing make package within net/freeradius2, the following error
is produced:

=> Creating binary package /usr/pkgsrc/packages/x86_64/All/freeradius-2.1.6.tgz
pkg_create: can't stat `/usr/pkg/bin/rlm_ippool_tool'
pkg_create: can't stat `/usr/pkg/lib/rlm_ippool-2.1.6.la'
pkg_create: can't stat `/usr/pkg/lib/rlm_ippool.la'
pkg_create: can't stat `/usr/pkg/man/man8/rlm_ippool_tool.8'
pkg_create: lstat failed for file bin/rlm_ippool_tool: No such file or directory
*** Error code 2  

Also, there is no rlm_perl module available (fails 'silently' on configure.
The following allows the module to build, though I have no idea what the real
fix is:

--- /usr/pkgsrc/net/freeradius2/options.mk      2009-09-13 01:36:51.000000000 
+1000
+++ /usr/pkgsrc/net/freeradius2/.#options.mk.1.2        2009-09-12 
14:43:31.000000000 +1000
@@ -1,15 +1,15 @@
 # $NetBSD: options.mk,v 1.2 2009/04/23 18:26:05 adam Exp $

 PKG_OPTIONS_VAR=       PKG_OPTIONS.freeradius
-PKG_SUPPORTED_OPTIONS= ldap mysql pgsql snmp kerberos pam freeradius-simul-use
-PKG_SUGGESTED_OPTIONS= gdbm freeradius-simul-use
+PKG_SUPPORTED_OPTIONS= ldap mysql pgsql snmp kerberos pam freeradius-simul-use 
perl
+PKG_SUGGESTED_OPTIONS= gdbm freeradius-simul-use perl
 PKG_OPTIONS_OPTIONAL_GROUPS=   dbm odbc
 PKG_OPTIONS_GROUP.dbm= bdb gdbm
 PKG_OPTIONS_GROUP.odbc=        iodbc unixodbc

 .include "../../mk/bsd.options.mk"

-PLIST_VARS+=   dbm gdbm iodbc ldap kerberos mysql pam pgsql unixodbc
+PLIST_VARS+=   dbm gdbm iodbc ldap kerberos mysql pam pgsql unixodbc perl

 ###
 ### GDBM or Berkeley DB 1.x support
@@ -133,3 +133,14 @@
 .else
 CONFIGURE_ARGS+=       --without-rlm_pam
 .endif
+
+###
+### PERL support
+###
+.if !empty(PKG_OPTIONS:Mperl)
+.  include "../../lang/perl5/buildlink3.mk"
+CONFIGURE_ARGS+=       --with-rlm_perl
+PLIST.perl=            yes
+.else
+CONFIGURE_ARGS+=       --without-rlm_perl
+.endif

>How-To-Repeat:

Make package with only the options 'mysql perl'. It may happen with
default options but I haven't tested.

>Fix:

>Unformatted: