pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/42043: Installing sysutils/libgtop with USE_DESTDIR results in wrong setgid binary

Here is an additional patch that uses SPECIAL_PERMS.

If this is applied, I think that patches/patch-da should still be
replaced by the above version because otherwise the build process
modifies files that are currently installed on the system (i.e. in
${PREFIX}, but outside ${DESTDIR}).

Index: Makefile
RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/libgtop/Makefile,v
retrieving revision 1.28
diff -p -U8 -r1.28 Makefile
--- Makefile    27 Aug 2009 20:03:17 -0000      1.28
+++ Makefile    11 Sep 2009 00:48:20 -0000
@@ -54,18 +54,17 @@ PLIST_VARS+=        server suid.h
 .elif ${OPSYS} == "SunOS"
 PLIST.server=  yes
 PLIST.server=  yes
 PLIST.suid.h=  yes
 .if defined(PLIST.server)
-       ${CHMOD} g+s ${DESTDIR}${PREFIX}/bin/libgtop_server2
+SPECIAL_PERMS+=                bin/libgtop_server2 ${REAL_ROOT_USER} kmem 2555
 PLIST_VARS+=    glibtop_private.h
 .if ${OPSYS} == "Linux" || ${OPSYS} == "SunOS" || ${OPSYS} == "FreeBSD" || 
${OPSYS} == "DragonFly"
 PLIST.glibtop_private.h= yes
 # XXX This needs a check in the configure script, which should be clean

Home | Main Index | Thread Index | Old Index