pkg/41990: shells/bash-4.0.28 doesn't build

[dholland%eecs.harvard.edu@localhost]

>Number:         41990
>Category:       pkg
>Synopsis:       shells/bash-4.0.28 doesn't build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 04 02:35:00 +0000 2009
>Originator:     David A. Holland
>Release:        pkgsrc-20090903
>Organization:
>Environment:
irrelevant
>Description:

bash40-025 contains this:

! #if 0
!         /* If we want all directories (dflags & GX_ALLDIRS) and we're not
!            being called recursively as something like `echo **/*.o'
!            ((flags & GX_ALLDIRS) == 0), we want to prevent glob_vector from
!            adding a null directory name to the front of the temp_results
!            array.  We turn off ADDCURDIR if not called recursively and
!            dlen == 0 */
! #endif

Note the unintended close-comment character. This chokes gcc3 and
probably at least some other compilers.

>How-To-Repeat:

make and/or inspection

>Fix:
patch in a space