pkg/41719: net/dhcpcd compile errors (NetBSD 4.0)

[kre%munnari.OZ.AU@localhost]

>Number:         41719
>Category:       pkg
>Synopsis:       net/dhcpcd compile errors (NetBSD 4.0)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 14 09:10:01 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0_STABLE
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        net/dhcpcd compilation on a NetBSD 4.0 system generates
        compile errors.

>How-To-Repeat:
        I use pkg_comp with libkver and NetBSD 4.0 release sets
        installed to simulate a pure NetBSD 4.0 environment.
        (I don't install the x* sets, but use pkgsrc modular xorg
        instead, but X is irrelevant to this package).

        Compiling net/dhcpcd results in ...

cc -O2 -std=c99   -DDBDIR=\"/var/db\" 
-DSCRIPT=\"/usr/pkg/libexec/dhcpcd-run-hooks\" -DSYSCONFDIR=\"/etc/conf\" -c 
if-pref.c -o if-pref.o
In file included from /usr/include/net/if.h:86,
                 from dhcpcd.h:32,
                 from if-pref.c:29:
/usr/include/net/pfil.h:79: error: expected specifier-qualifier-list before 
'u_long'
*** Error code 1

Stop.
make: stopped in /pkg_comp/obj/pkgsrc/net/dhcpcd/4x/dhcpcd-5.0.6
*** Error code 1

Stop.

        Line 79 of pfil.h (on NetBSD 4.0) is ...

                u_long          phu_val;

        which occurs in

        union {
                u_long          phu_val;
                void            *phu_ptr;
        } ph_un;
#define ph_af           ph_un.phu_val
#define ph_ifnet        ph_un.phu_ptr

        which is a part of

struct pfil_head {
        pfil_list_t     ph_in;
        pfil_list_t     ph_out;
        pfil_list_t     ph_ifaddr;
        pfil_list_t     ph_ifnetevent; /* XXX naming collision */
        int             ph_type;
        union {
                u_long          phu_val;
                void            *phu_ptr;
        } ph_un;
#define ph_af           ph_un.phu_val
#define ph_ifnet        ph_un.phu_ptr
        LIST_ENTRY(pfil_head) ph_list;
};
typedef struct pfil_head pfil_head_t;


>Fix:
        Maybe a required #include (for NetBSD 4) is missing?
        (maybe sys/types.h though it's hard to see how it could
        possibly have compiled so successfully without that one).