pkg/41646: [patch] graphics/graphviz PLIST should use PERL5_SUB_INSTALLVENDORARCH

[Tom Yu <tlyu%MIT.EDU@localhost>]

>Number:         41646
>Category:       pkg
>Synopsis:       [patch] graphics/graphviz PLIST should use 
>PERL5_SUB_INSTALLVENDORARCH
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 28 22:20:01 +0000 2009
>Originator:     Tom Yu
>Release:        pkgsrc trunk 20090626
>Organization:

>Environment:
Darwin SPARK-GAP.MIT.EDU 9.7.0 Darwin Kernel Version 9.7.0: Tue Mar 31 22:52:17 
PDT 2009; root:xnu-1228.12.14~1/RELEASE_I386 i386
>Description:
Building the package for graphics/graphviz on Mac OS X 10.5.7 (Intel)
fails because the PLIST tries to explicitly construct the equivalent
of PERL5_SUB_INSTALLVENDORARCH instead of actually using that
variable.  The build outputs errors such as

pkg_create: can't stat 
`/usr/pkg/lib/perl5/vendor_perl/5.10.0/i386-darwin-thread-multi/gv.pm'
pkg_create: can't stat 
`/usr/pkg/lib/perl5/vendor_perl/5.10.0/i386-darwin-thread-multi/gv.so'

The arch component of the pathname should actually be
"darwin-thread-multi-2level".  The PLIST should use the
PERL5_SUB_INSTALLVENDORARCH variable instead, which lang/perl5/vars.mk
already sets correctly.  (graphics/graphiviz/options.mk includes
lang/perl5/buildlink3.mk which includes lang/perl5/vars.mk when
building with perl)

>How-To-Repeat:
Attempt to "bmake package" in graphics/graphviz on Mac OS X 10.5.7
(Intel), or probably in other Mac OS X environments as well.

>Fix:
Patch the PLIST as follows:

Index: graphics/graphviz/PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/graphviz/PLIST,v
retrieving revision 1.34
diff -u -r1.34 PLIST
--- graphics/graphviz/PLIST     14 Jun 2009 20:05:42 -0000      1.34
+++ graphics/graphviz/PLIST     28 Jun 2009 21:57:51 -0000
@@ -88,8 +88,8 @@
 lib/libgraph.la
 lib/libgvc.la
 lib/libpathplan.la
-${PLIST.perl}lib/perl5/vendor_perl/5.10.0/${MACHINE_ARCH}-${LOWER_OPSYS}-thread-multi/gv.pm
-${PLIST.perl}lib/perl5/vendor_perl/5.10.0/${MACHINE_ARCH}-${LOWER_OPSYS}-thread-multi/gv.so
+${PLIST.perl}${PERL5_SUB_INSTALLVENDORARCH}/gv.pm
+${PLIST.perl}${PERL5_SUB_INSTALLVENDORARCH}/gv.so
 lib/pkgconfig/libcdt.pc
 lib/pkgconfig/libcgraph.pc
 lib/pkgconfig/libgraph.pc