pkg/41219: audio/jack fails to build under Linux [patch]

[cheusov%tut.by@localhost]

>Number:         41219
>Category:       pkg
>Synopsis:       audio/jack fails to build under Linux [patch]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 15 09:30:00 +0000 2009
>Originator:     Aleksey Cheusov
>Release:        linux
>Organization:
home
>Environment:
linux
>Description:
audio/jack fails under Linux like this
     gcc -DHAVE_CONFIG_H -I. -I.. 
-I/tmp/obj_pkgsrc/audio/jack/work/.buildlink/include -I../config     
-D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -Wall -g -O2 
-DDEVOSSAUDIO=\"/dev/audio\" -I/usr/include/nptl -pthread 
-DJACK_LOCATION=\"/usr/pkg/bin\" -Wall -g -O2 -DDEVOSSAUDIO=\"/dev/audio\" 
-pthread -MT libjack_la-client.lo -MD -MP -MF .deps/libjack_la-client.Tpo -c 
client.c  -fPIC -DPIC -o .libs/libjack_la-client.o
In file included from client.c:42:
    ../jack/engine.h:83: error: expected specifier-qualifier-list before 
'pthread_rwlock_t'
    client.c: In function 'jack_client_alloc_internal':
    client.c:356: error: 'jack_engine_t' has no member named 'port_segment'
    *** Error code 1

This happens because for some unknown reason pthread_rwlock_t declaration in 
GLIBC is "hidden" under #defines.

To fix the problem it is enough to add _GNU_SOURCE to CFLAGS.

Full report is here
http://mova.org/~cheusov/pub/pkgsrc-distbb/Linux/current/logs/20090410.2105/audio_jack_jack-0.115.1/stage_build.html

>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/jack/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile    16 Nov 2008 11:55:19 -0000      1.13
+++ Makefile    15 Apr 2009 09:20:16 -0000
@@ -35,6 +35,7 @@
 CONFIGURE_ARGS+=       --enable-timestamps
 
 CFLAGS.NetBSD+=                -D_NETBSD_SOURCE
+CFLAGS.Linux+=         -D_GNU_SOURCE
 
 CONFIGURE_ENV+=                ac_cv_header_readline_chardefs_h=yes