Re: pkg/38069

[Timothy Redaelli <drizzt%gentoo.org@localhost>]

The following reply was made to PR pkg/38069; it has been noted by GNATS.

From: Timothy Redaelli <drizzt%gentoo.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/38069
Date: Tue, 24 Feb 2009 17:49:03 +0100

 --Boundary-00=_/TCpJWjr8kJ77b0
 Content-Type: text/plain;
   charset="utf-8"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Hi,
 I have a patch su suggest.
 We can move the checks for library functions before the checks for libraries
 
 -- 
 Timothy `Drizzt` Redaelli
 FreeSBIE Developer, Gentoo Developer, GUFI Staff
 There are two major products that come out of Berkeley: LSD and UNIX.
 We don't believe this to be a coincidence.      -- Jeremy S. Anderson
 
 --Boundary-00=_/TCpJWjr8kJ77b0
 Content-Type: text/x-diff;
   charset="iso 8859-15";
   name="tnftp.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
        filename="tnftp.patch"
 
 Index: configure.ac
 ===================================================================
 RCS file: /cvsroot/pkgsrc/net/tnftp/files/configure.ac,v
 retrieving revision 1.1.1.1
 diff -u -b -B -r1.1.1.1 configure.ac
 --- configure.ac       6 Aug 2007 04:42:53 -0000       1.1.1.1
 +++ configure.ac       24 Feb 2009 16:47:55 -0000
 @@ -77,6 +77,28 @@
          )
  
  #
 +# Checks for library functions.
 +#
 +#XXX    remove alloca use
 +AC_FUNC_ALLOCA
 +AC_FUNC_CLOSEDIR_VOID
 +AC_FUNC_FORK
 +AC_FUNC_FSEEKO
 +AC_FUNC_STRCOLL
 +AC_REPLACE_FUNCS([dirname err fgetln getaddrinfo getnameinfo \
 +                  inet_ntop inet_pton mkstemp setprogname sl_init snprintf \
 +                  strdup strerror strlcat strlcpy strptime strsep strunvis \
 +                  strvis timegm usleep utimes])
 +AC_CHECK_FUNCS([getcwd gethostbyaddr gethostbyname gethostbyname2 gethostname 
\
 +                getpass getpassphrase getpgrp gettimeofday isascii \
 +                memchr memmove memset realpath regcomp \
 +                select setlocale socket strcasecmp strchr strcspn strdup \
 +                strerror strncasecmp strpbrk strrchr strstr strtol strtoul \
 +                utime])
 +AS_IF([test "$ac_cv_func_getpgrp" = yes], [AC_FUNC_GETPGRP])
 +AS_IF([test "$ac_cv_func_strptime" = yes], [AC_CHECK_DECLS([strptime])])
 +
 +#
  # Checks for libraries.
  #
  AS_IF([test "$opt_editcomplete" = yes],
 @@ -223,28 +245,6 @@
  ])
         AC_CHECK_TYPES([struct sockaddr_in6], [], [], [$accheck_includes])])
  
 -#
 -# Checks for library functions.
 -#
 -#XXX    remove alloca use
 -AC_FUNC_ALLOCA
 -AC_FUNC_CLOSEDIR_VOID
 -AC_FUNC_FORK
 -AC_FUNC_FSEEKO
 -AC_FUNC_STRCOLL
 -AC_REPLACE_FUNCS([dirname err fgetln getaddrinfo getnameinfo \
 -                  inet_ntop inet_pton mkstemp setprogname sl_init snprintf \
 -                  strdup strerror strlcat strlcpy strptime strsep strunvis \
 -                  strvis timegm usleep utimes])
 -AC_CHECK_FUNCS([getcwd gethostbyaddr gethostbyname gethostbyname2 gethostname 
\
 -                getpass getpassphrase getpgrp gettimeofday isascii \
 -                memchr memmove memset realpath regcomp \
 -                select setlocale socket strcasecmp strchr strcspn strdup \
 -                strerror strncasecmp strpbrk strrchr strstr strtol strtoul \
 -                utime])
 -AS_IF([test "$ac_cv_func_getpgrp" = yes], [AC_FUNC_GETPGRP])
 -AS_IF([test "$ac_cv_func_strptime" = yes], [AC_CHECK_DECLS([strptime])])
 -
  # Always replace glob(); the vendor's may not be secure.
  #
  AC_LIBOBJ([glob])
 
 --Boundary-00=_/TCpJWjr8kJ77b0--