pkg/40567: net/openvpn fails to compile on Solaris 10

[kawakubo.pr%gmail.com@localhost]

>Number:         40567
>Category:       pkg
>Synopsis:       net/openvpn fails to compile on Solaris 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 06 13:15:01 +0000 2009
>Originator:     KAWAKUBO Hiroshi
>Release:        pkgsrc-current on Solaris 10
>Organization:
>Environment:
SunOS XXX 5.10 Generic_137138-09 i86pc i386 i86pc
>Description:
net/openvpn fails to compile on Solaris 10 with the following error:

gcc -DHAVE_CONFIG_H -I. -I. -I.    -I/usr/include -I/usr/pkg/include 
-I/usr/pkg/gcc34/include 
-I/usr/pkg/gcc34/lib/gcc/i386-pc-solaris2.10/3.4.6/include -I.  -O 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/gcc34/include 
-I/usr/pkg/gcc34/lib/gcc/i386-pc-solaris2.10/3.4.6/include -c tun.c
tun.c: In function `do_ifconfig':
tun.c:724: error: `command_line' undeclared (first use in this function)
tun.c:724: error: (Each undeclared identifier is reported only once
tun.c:724: error: for each function it appears in.)
*** Error code 1
>How-To-Repeat:

>Fix:
patch-ac needs to be updated.

--- patches/patch-ac.orig       2007-06-21 21:44:42.000000000 +0000
+++ patches/patch-ac
@@ -9,21 +9,22 @@
  #endif
  
  bool
-@@ -720,7 +721,12 @@
+@@ -720,7 +721,13 @@
                            );
        }
        else
 -      no_tap_ifconfig ();
-+      openvpn_snprintf (command_line, sizeof (command_line),
-+                        IFCONFIG_PATH " %s %s netmask %s broadcast + up",
-+                        actual,
-+                        ifconfig_local,
-+                        ifconfig_remote_netmask
-+                        );
++        argv_printf (&argv,
++                          "%s %s netmask %s broadcast + up",
++                          IFCONFIG_PATH,
++                          actual,
++                          ifconfig_local,
++                          ifconfig_remote_netmask
++                          );
  
        argv_msg (M_INFO, &argv);
        if (!openvpn_execve_check (&argv, es, 0, "Solaris ifconfig phase-2 
failed"))