pkg/40254: pkgsrc/graphics/MesaLib/builtin.mk changes USE_BUILTIN.pthread if X11_TYPE=modular

[zingelman%fnal.gov@localhost]

>Number:         40254
>Category:       pkg
>Synopsis:       pkgsrc/graphics/MesaLib/builtin.mk changes USE_BUILTIN.pthread 
>if X11_TYPE=modular
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 22 19:40:00 +0000 2008
>Originator:     Tim
>Release:        pkgsrc current
>Organization:
Fermilab
>Environment:
SunOS hostname 5.10 Generic_137111-05 sun4u sparc SUNW,Sun-Fire-V440
>Description:
pkgsrc/graphics/MesaLib/builtin.mk includes ../../mk/pthread.builtin.mk which 
resets the value of BUILTIN_PKG to pthread.

pkgsrc/graphics/MesaLib/builtin.mk then includes ../../mk/x11.builtin.mk which, 
if X11_TYPE=modular is set, changes USE_BUILTIN.pthread to no

This results in at least this spurious message:
 pkg_info: missing package name(s)
 usage: pkg_info [-BbcDdFfhIikLmNnpqRSsVvX] [-e package] [-E package]
                [-K pkg_dbdir] [-l prefix] pkg-name ...
       pkg_info [-a | -u] [flags]
       pkg_info [-Q variable] pkg-name ...
as well as I'm not sure what else breakage.

It is not clear to me if other packages might do the same thing?  Should 
pthread.builtin.mk preserve and re-set BUILTIN_PKG, or should MesaLib be fixed?
>How-To-Repeat:
On a platform with only a builtin pthreads:
set X11_TYPE=modular
cd pkgsrc/graphics/MesaLib
bmake configure
>Fix:
Maybe re-arrange the order of builtin.mk in MesaLib to put the x11.builtin.mk 
include before the pthreads one?  Or should ../../mk/pthread.builtin.mk 
preserve the value of BUILTIN_PKG?

I think this is broken on any platform with a builtin pthreads and with 
X11_TYPE=modular set.