Re: pkg/40155: make net/pppd package work on dragonfly

[B K <mtbakerguy%yahoo.com@localhost>]

The following reply was made to PR pkg/40155; it has been noted by GNATS.

From: B K <mtbakerguy%yahoo.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: hasso%estpak.ee@localhost
Subject: Re: pkg/40155: make net/pppd package work on dragonfly
Date: Wed, 17 Dec 2008 23:17:16 -0800 (PST)

 Sometimes you ought to build things before trying.  I fought with bmake to 
figure out the :!cmd! syntax to do the following:
 
 .if ${:!/usr/bin/uname -s!} == "DragonFly"
 LIBS += -lcipher -lmd
 .endif
 
 and then realized with I tried to do the build that it uses gmake with the 
saner $(shell /usr/bin/uname -s) syntax so you really just need to insert 
something like the following into patches/patch-aj:
 
 LIBS=-lutil
 ifeq ($(shell /usr/bin/uname -s),DragonFly)
 LIBS += -lcipher -lmd
 endif
 
 I considered sending a brand new patch in its entirety but figured that'd 
clutter up the change request and obscure the change.  Likewise, I debated 
about either additional pathname lookups for uname or perhaps just using 
$(shell uname -s) and letting the contents of PATH drive the lookup.  
Eventually I decided to use the explicity /usr/bin path.
 
 B K
 
 
 --- On Tue, 12/16/08, Hasso Tepper <hasso%estpak.ee@localhost> wrote:
 
 > From: Hasso Tepper <hasso%estpak.ee@localhost>
 > Subject: Re: pkg/40155: make net/pppd package work on dragonfly
 > To: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
 > pkgsrc-bugs%netbsd.org@localhost, mtbakerguy%yahoo.com@localhost
 > Date: Tuesday, December 16, 2008, 7:15 AM
 > The following reply was made to PR pkg/40155; it has been
 > noted by GNATS.
 > 
 > From: Hasso Tepper <hasso%estpak.ee@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/40155: make net/pppd package work on
 > dragonfly
 > Date: Tue, 16 Dec 2008 17:11:24 +0200
 > 
 >  mtbakerguy%yahoo.com@localhost wrote:
 >  > This package should compile and run on dragonfly. 
 > The attached patch 
 >  > does the build and I've done some rudimentary
 > testing.  Specifically, I 
 >  > needed the pty capability to run ppp over an SSL
 > connection.
 >  
 >  Nice, except that this change breaks it for NetBSD, which
 > isn't acceptable 
 >  of course:
 >  
 >  > -+LIBS = -lutil
 >  > ++LIBS = -lutil -lmd -lcipher
 >  
 >  Can you rework this fix so that it doesn't break
 > currently working 
 >  platform(s)?
 >  
 >  
 >  -- 
 >  Hasso Tepper