pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/39977 CVS commit: pkgsrc/sysutils/fdupes

The following reply was made to PR pkg/39977; it has been noted by GNATS.

From: "OBATA Akio" <>
Subject: Re: PR/39977 CVS commit: pkgsrc/sysutils/fdupes
Date: Thu, 18 Dec 2008 09:49:56 +0900

 On Thu, 18 Dec 2008 05:50:04 +0900, Edgar FuÃ? <> 
 >  patch-aa seems to be in a strange diff format that has extra stuff at
 >  the end of the "@@" lines. What's that for?
 Just regen patch files with mkpatches(1) (pkgtools/pkgdiff).
 It make easier to maintain patches.
 See also '-p' option of diff(1).
 >  In Makefile, you changed INSTALL_MAKE_FLAGS to MAKE_FLAGS. Why is
 >  that preferable?
 For current version, no differ.
 But basically, those variables should not be changed from build to install 
 >  In Makefile, you added INSTALLATION_DIRS= bin ${PKGMANDIR}/man1. Is
 >  that really necessary?
 In Makefile of fdupes, it is assumed that those directories preexists,
 so need to create before installation phase.
 It will be failed to install without INSTALLATION_DIRS if 

Home | Main Index | Thread Index | Old Index