pkg/39925: bacula (2.2.4) fails compiling with postgresql83 (as of 8.3.5)

[Rainer.Pruy%acrys.com@localhost]

>Number:         39925
>Category:       pkg
>Synopsis:       bacula (2.2.4) fails compiling with postgresql83 (as of 8.3.5)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 15 15:10:00 +0000 2008
>Originator:     Rainer Pruy
>Release:        4.0.1
>Organization:
>Environment:
n/a
>Description:
building bacula (2.2.4) from pkgsrc (current)
with PKG_OPTIONS.bacula=catalog-pgsql
aborts with error in file .../work/bacula-2.2.4/src/cats/postgresql.c

Reason:

constant NAMEDATALEN is no longer defined in postgres_ext.h but in 
pg_config_manual.h.



>How-To-Repeat:
Install postresql83 = 8.3.5 and then "make  install" in bacula having option 
catalog-pgsql active.
>Fix:
patch postgresql.c (included):

---------------cut-------------
--- src/cats/postgresql.c.orig  2007-09-07 14:57:05.000000000 +0200
+++ src/cats/postgresql.c
@@ -46,7 +46,7 @@

 #ifdef HAVE_POSTGRESQL

-#include "postgres_ext.h"       /* needed for NAMEDATALEN */
+#include "pg_config_manual.h"       /* needed for NAMEDATALEN */

 /* -----------------------------------------------------------------------
  *
---------------cut---------------


Obviously this fix would prevent bacula to be compatible with postgres < 8.3 
thus it proably should be applied conditionally or the relevant include 
selected depending on some define?