Re: pkg/39451 (bsdtar fails on Linux)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/39451; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: Aleksey Cheusov <cheusov%tut.by@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, joerg%NetBSD.org@localhost, 
pkg-manager%netbsd.org@localhost,
        pkgsrc-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
obache%NetBSD.org@localhost
Subject: Re: pkg/39451 (bsdtar fails on Linux)
Date: Sun, 2 Nov 2008 02:27:00 +0000

 On Sat, Sep 13, 2008 at 11:03:18AM +0300, Aleksey Cheusov wrote:
  > The following patch fixes the problem.
  > [...]
  > -#ifdef __linux
  > +#ifdef HAVE_EXT2FS_EXT2_FS_H
  >     if ((S_ISREG(st->st_mode) || S_ISDIR(st->st_mode)) &&
  >         ((fd = open(accpath, O_RDONLY|O_NONBLOCK)) >= 0) &&
  >         ((r = ioctl(fd, EXT2_IOC_GETFLAGS, &stflags)), [...]
 
 You have a Linux machine that doesn't have ext2fs? That seems... odd,
 and if that's not the issue then this isn't really the right fix;
 instead it should be patched to include the right header or use the
 proper alternative ioctl or whatnot.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost