pkg/39819: audio/rplay build fails unnoticed on Solaris

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         39819
>Category:       pkg
>Synopsis:       audio/rplay build fails unnoticed on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 28 14:15:00 +0000 2008
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
SunOS spare4200 5.10 Generic_120012-14 i86pc i386 i86pc

>Description:
Compiling audio/rplay fails with two errors:


gcc -c -I/usr/local/pkgsrc/pkgsrc-cvs/include -I. -I../include -I. 
-I./../include  -I./../lib -I./../adpcm   -DHAVE_CONFIG_H  
-DRPLAY_CONF=\"/usr/local/pkgsrc/pkgsrc-cvs/etc/rplay.conf\"  
-DRPLAY_HOSTS=\"/usr/local/pkgsrc/pkgsrc-cvs/etc/rplay.hosts\"  
-DRPLAY_SERVERS=\"/usr/local/pkgsrc/pkgsrc-cvs/etc/rplay.servers\"  
-DRPLAY_HELPERS=\"/usr/local/pkgsrc/pkgsrc-cvs/etc/rplay.helpers\"  
-DRPLAY_CACHE=\"/tmp/.rplay-cache\"  -DRPLAY_LOG=\"/tmp/rplay.log\"  
-DRPLAYDRC=\"\~/.rplaydrc\" -O -I/usr/local/pkgsrc/pkgsrc-cvs/include cdrom.c
cdrom.c: In function `internal_cdda_read':
cdrom.c:342: error: `errno' undeclared (first use in this function)
cdrom.c:342: error: (Each undeclared identifier is reported only once
cdrom.c:342: error: for each function it appears in.)
*** Error code 1

Stop.
bmake: stopped in 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/rplay-3.3.2/rplayd
make all in rplay...
gcc -c -I/usr/local/pkgsrc/pkgsrc-cvs/include -I. -I../include -I./../include 
-I./../lib -DHAVE_CONFIG_H -O -I/usr/local/pkgsrc/pkgsrc-cvs/include rplay.c

...

gcc -o .libs/rptp rptp.o -Wl,-R/usr/local/pkgsrc/pkgsrc-cvs/lib  
../librplay/.libs/librplay.so 
-L/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.buildlink/lib
 ../lib/librp.a -ledit 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.buildlink/lib/libncurses.so
 -lsocket -lnsl  -R/usr/local/pkgsrc/pkgsrc-cvs/lib 
-R/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.buildlink/lib
ld: fatal: library -ledit: not found
ld: warning: symbol `raw' has differing types:
        (file rptp.o type=OBJT; file 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.buildlink/lib/libncurses.so
 type=FUNC);
        rptp.o definition taken
ld: warning: symbol `raw' has differing types:
        (file rptp.o type=OBJT; file 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.buildlink/lib/libncurses.so
 type=FUNC);
ld: fatal: File processing errors. No output written to .libs/rptp
collect2: ld returned 1 exit status
*** Error code 1

Stop.
bmake: stopped in 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/rplay-3.3.2/rptp
make all in doc...
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.tools/bin/makeinfo
  RPLAY.texi
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.tools/bin/makeinfo
  RPTP.texi
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.tools/bin/makeinfo
  librplay.texi
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/.tools/bin/makeinfo
  rplay.texi
=> Unwrapping files-to-be-installed.
=> Creating 
/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/audio/rplay/work.spare4200/rplayd


Yet, in both cases the build continues. It even finishes, and "make install" 
will install an incomplete  package. Especially ".../sbin/rplayd" and 
".../bin/rptp" will be missing.
>How-To-Repeat:
"make"
>Fix:
Regarding the first error:

rplay-3.3.2/rplayd/cdrom.c incorrectly includes "sys/errno.h" instead of 
"errno.h". This should probably get fixed upstream, if there is such a thing as 
"upstream" left. Other files in this directory either already include "errno.h" 
or simply both files.

Regarding the second error:

Is libedit a NetBSD speciality? It is not included in devel/readline. Anyway: 
Just removing -ledit from the LDFLAGS leaves a working rptp binary.

Regarding the fact, that these errors are not caught:

Unknown.