pkg/39612: gnutls does not build with Sun Studio compilers

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         39612
>Category:       pkg
>Synopsis:       gnutls does not build with Sun Studio compilers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 23 08:05:00 +0000 2008
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
SunOS spare4200 5.10 Generic_120012-14 i86pc i386 i86pc

>Description:
security/gnutls (both 2.4.1 from 2008Q2 and current, and the already released 
2.4.2) contains two issues that prevent the compilation with Sun's SPro 
compilers.

The problem in lib/gnutls_cipher_int.c is discussed in

http://lists.gnu.org/archive/html/gnutls-devel/2008-09/msg00002.html

I don't think it's the best possible solution, though...

In addition, doc/examples/ex-cxx.cpp fails with Sun's CC. As this is "only" an 
example, that is not even installed, I decided to totally skip this 
subdirectory (after trying to fix the problem for real).
>How-To-Repeat:
compile with Sun Studio
>Fix:
from the GNU TLS mailing list:

--- ./lib/gnutls_cipher_int.c   2008/09/23 07:27:41     1.1
+++ ./lib/gnutls_cipher_int.c   2008/09/23 07:27:56
@@ -174,7 +174,8 @@
   if (handle != NULL)
     {
       if (handle->registered && handle->hd.rh.ctx != NULL) {
-        return handle->hd.rh.cc->deinit( handle->hd.rh.ctx);
+        handle->hd.rh.cc->deinit( handle->hd.rh.ctx);
+       return;
       }
       gc_cipher_close (handle->hd.gc);
     }

and

--- ./doc/Makefile.in   2008/09/23 07:23:07     1.1
+++ ./doc/Makefile.in   2008/09/23 07:23:37
@@ -576,7 +576,7 @@
 top_srcdir = @top_srcdir@
 EXTRA_DIST = TODO README.GIT README.autoconf certtool.cfg gnutls.ps \
        gnutls.pdf gnutls.html extract-guile-c-doc.scm $(guile_texi)
-SUBDIRS = examples scripts manpages credentials $(am__append_1)
+SUBDIRS = scripts manpages credentials $(am__append_1)
 info_TEXINFOS = gnutls.texi
 
 # Images.  Make sure there are eps + png + pdf of each, plus the source dia.