pkg/39443: DESTDIR support for pkgtools/pkgfind

[leonardo1990%gmail.com@localhost]

>Number:         39443
>Category:       pkg
>Synopsis:       pkgtools/pkgfind: doesn't support DESTDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 01 00:40:00 +0000 2008
>Originator:     Leonardo Taccari
>Release:        NetBSD 4.0
>Organization:
NetBSD Italia
>Environment:


System: NetBSD bianconiglio 4.0 NetBSD 4.0 (BIANCONIGLIO) #3: Tue Jul 1 
06:54:05 CEST 2008 
leot@bianconiglio:/home/leot/builds/usr/src/sys/arch/i386/compile/BIANCONIGLIO 
i386
Architecture: i386
Machine: i386
>Description:
pkgtools/pkgfind doesn't support DESTDIR and pkgtools/pkglint warns
about the @${CP}.
>How-To-Repeat:
For the former:

        $ cd ${PKGSRCDIR}/pkgtools/pkgfind
        $ USE_DESTDIR=full make install

For the latter:

        $ cd ${PKGSRCDIR}/pkgtools/pkgfind
        $ pkglint -Wall
        WARN: Makefile:20: The shell command "${CP}" should not be hidden.
        0 errors and 1 warnings found.
>Fix:
Please apply the following patch. Thank you very much!


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkgfind/Makefile,v
retrieving revision 1.20
diff -u -p -r1.20 Makefile
--- Makefile    27 Dec 2007 23:19:06 -0000      1.20
+++ Makefile    31 Aug 2008 20:43:12 -0000
@@ -8,6 +8,7 @@ DISTFILES=      # empty
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
 COMMENT=       Find packages by package name in pkgsrc
 
+PKG_DESTDIR_SUPPORT=   user-destdir
 PKG_INSTALLATION_TYPES=        overwrite pkgviews
 
 NO_CHECKSUM=   yes
@@ -17,15 +18,15 @@ USE_FEATURES=       err getprogname setprognam
 INSTALLATION_DIRS=     bin ${PKGMANDIR}/man1
 
 do-extract:
-       @${CP} -R ${FILESDIR} ${WRKSRC}
+       ${RUN} ${CP} -R ${FILESDIR} ${WRKSRC}
 
 do-build:
        ${CC} ${CFLAGS} ${CPPFLAGS} ${LDFLAGS} -o ${WRKSRC}/pkgfind     \
                ${WRKSRC}/pkgfind.c ${LIBS}
 
 do-install:
-       ${INSTALL_PROGRAM} ${WRKSRC}/pkgfind ${PREFIX}/bin/pkgfind
-       ${INSTALL_MAN} ${WRKSRC}/pkgfind.1 ${PREFIX}/${PKGMANDIR}/man1/pkgfind.1
+       ${INSTALL_PROGRAM} ${WRKSRC}/pkgfind ${DESTDIR}${PREFIX}/bin/pkgfind
+       ${INSTALL_MAN} ${WRKSRC}/pkgfind.1 
${DESTDIR}${PREFIX}/${PKGMANDIR}/man1/pkgfind.1
 
 SUBST_CLASSES+=                path
 SUBST_STAGE.path=      post-patch

>Unformatted: