pkg/39286: multimedia/xine-lib doesn't build after recent changes

[hasso%estpak.ee@localhost]

>Number:         39286
>Category:       pkg
>Synopsis:       multimedia/xine-lib doesn't build after recent changes
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 04 19:30:00 +0000 2008
>Originator:     Hasso Tepper
>Release:        DragonFly
>Organization:
>Environment:
DragonFly
>Description:
multimedia/xine-lib is broken at least in DragonFly after recent changes 
enabling XvMC support:

/bin/sh ../../libtool --tag=CC   --mode=link cc -fvisibility=hidden 
-I/usr/pkg/include   -I/usr/pkg/include   -D_REENTRANT -D_FILE_OFFSET_BITS=64 
-DXINE_COMPILE   -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute 
-Werror-implicit-function-declaration -Wstrict-aliasing=2 -mtune=i386 -O3 -pipe 
-fomit-frame-pointer -falign-functions=4 -falign-loops=4 -falign-jumps=4   
-fexpensive-optimizations -fschedule-insns2 -ffast-math -finline-functions 
-Wall -Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts 
-Wmissing-declarations -Wmissing-prototypes -O2 -I/usr/pkg/include 
-I/usr/pkg/include/freetype2 -I/usr/include -DNDEBUG -Wl,-z,defs -avoid-version 
-module -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -o 
xineplug_vo_out_xvmc.la -rpath /usr/pkg/lib/xine/plugins/1.23 
xineplug_vo_out_xvmc_la-deinterlace.lo 
xineplug_vo_out_xvmc_la-video_out_xvmc.lo ../../src/xine-engine/libxine.la -L 
-lXvMCW -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lXv   -Wl,-R/usr/pkg/lib 
 -L/usr/pkg/lib -lX11 -lXext   -pthread -lpthread -L/usr/pkg/lib -lintl 
-R/usr/pkg/lib
cd: unknown option: -l
libtool: link: cannot determine absolute directory name of `-lXvMCW'
cc -shared  .libs/xineplug_vo_out_xvmc_la-deinterlace.o 
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o  -Wl,--rpath 
-Wl,/scratch/multimedia/xine-lib/work/xine-lib-1.1.14/src/xine-engine/.libs 
-Wl,--rpath -Wl,/scratch/multimedia/xine-lib/work/.buildlink/lib -Wl,--rpath 
-Wl,/usr/pkg/lib -Wl,--rpath 
-Wl,/scratch/multimedia/xine-lib/work/.buildlink/lib 
-L/scratch/multimedia/xine-lib/work/.buildlink/lib 
../../src/xine-engine/.libs/libxine.so -L-lXvMCW 
/scratch/multimedia/xine-lib/work/.buildlink/lib/libXv.so 
/scratch/multimedia/xine-lib/work/.buildlink/lib/libX11.so 
/scratch/multimedia/xine-lib/work/.buildlink/lib/libXext.so -pthread -lpthread 
/scratch/multimedia/xine-lib/work/.buildlink/lib/libintl.so  -mtune=i386 -Wl,-z 
-Wl,defs -Wl,-R/usr/pkg/lib -pthread -pthread -pthread -Wl,-soname 
-Wl,xineplug_vo_out_xvmc.so -o .libs/xineplug_vo_out_xvmc.so
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function `init_class':
video_out_xvmc.c:(.text+0x16d): undefined reference to `XvMCQueryExtension'
video_out_xvmc.c:(.text+0x22a): undefined reference to `XvMCListSurfaceTypes'
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function `xvmc_dispose':
video_out_xvmc.c:(.text+0x14d8): undefined reference to `XvMCHideSurface'
video_out_xvmc.c:(.text+0x14ef): undefined reference to `XvMCDestroySurface'
video_out_xvmc.c:(.text+0x150d): undefined reference to `XvMCDestroyContext'
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function 
`xvmc_gui_data_exchange':
video_out_xvmc.c:(.text+0x1695): undefined reference to `XvMCPutSurface'
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function 
`xvmc_update_frame_format':
video_out_xvmc.c:(.text+0x199a): undefined reference to `XvMCDestroyBlocks'
video_out_xvmc.c:(.text+0x19a7): undefined reference to `XvMCDestroyMacroBlocks'
video_out_xvmc.c:(.text+0x19d0): undefined reference to `XvMCFlushSurface'
video_out_xvmc.c:(.text+0x19e7): undefined reference to `XvMCSyncSurface'
video_out_xvmc.c:(.text+0x19fe): undefined reference to `XvMCDestroySurface'
video_out_xvmc.c:(.text+0x1a1c): undefined reference to `XvMCDestroyContext'
video_out_xvmc.c:(.text+0x1a46): undefined reference to `XvMCCreateContext'
video_out_xvmc.c:(.text+0x1a83): undefined reference to `XvMCCreateSurface'
video_out_xvmc.c:(.text+0x1ab4): undefined reference to `XvMCCreateBlocks'
video_out_xvmc.c:(.text+0x1ad0): undefined reference to `XvMCCreateMacroBlocks'
video_out_xvmc.c:(.text+0x1ba2): undefined reference to `XvMCDestroyContext'
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function 
`xvmc_display_frame':
video_out_xvmc.c:(.text+0x1eb6): undefined reference to `XvMCSyncSurface'
video_out_xvmc.c:(.text+0x1f29): undefined reference to `XvMCPutSurface'
.libs/xineplug_vo_out_xvmc_la-video_out_xvmc.o: In function 
`xvmc_proc_macro_block':
video_out_xvmc.c:(.text+0x21c1): undefined reference to `XvMCRenderSurface'
video_out_xvmc.c:(.text+0x21cd): undefined reference to `XvMCFlushSurface'
video_out_xvmc.c:(.text+0x22c6): undefined reference to `XvMCRenderSurface'
video_out_xvmc.c:(.text+0x22d2): undefined reference to `XvMCFlushSurface'
gmake[3]: *** [xineplug_vo_out_xvmc.la] Error 1
gmake[3]: Leaving directory 
`/scratch/multimedia/xine-lib/work/xine-lib-1.1.14/src/video_out'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory 
`/scratch/multimedia/xine-lib/work/xine-lib-1.1.14/src/video_out'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory 
`/scratch/multimedia/xine-lib/work/xine-lib-1.1.14/src'
gmake: *** [all-recursive] Error 1
*** Error code 2

>How-To-Repeat:

>Fix:
The source of the problem is that configure script fails to detect X libraries 
and includes paths. X libraries path is blindly (without checking whether it's 
empty) used to construct XVMC_LIBS.

There is two possible solutions:

* Fix detecting X libraries and includes paths. It's trivial with adding xmkmf 
to USE_TOOLS.
* Go to hack configure.ac.

I'd prefer the first solution - trivial and has potential to avoid similar 
problems in the future.