pkg/39117: Package xfce4-exo Makefile adds -msse to CFLAGS; older CPUs forsaken.

[ehynan%suffolk.lib.ny.us@localhost]

>Number:         39117
>Category:       pkg
>Synopsis:       Package xfce4-exo Makefile adds -msse to CFLAGS; older CPUs 
>forsaken.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 08 22:35:00 +0000 2008
>Originator:     Ed Hynan
>Release:        4.0-RELEASE
>Organization:
>Environment:
NetBSD stella 4.0 NetBSD 4.0 (STELLA) #0: Sat Jun 28 23:10:30 EDT 2008  
root@stella:/usr/src/sys/arch/i386/compile/STELLA i386

Machine has AMD k6-3 CPU

>Description:
Found in /usr/pkgsrc/x11/xfce4-exo/Makefile lines 14-18:

.if !empty(OPSYS:MNetBSD)
.  if exists(/usr/include/mmintrin.h)
CFLAGS+=       -msse   
.  endif
.endif 

I was led to find that by the illegal instruction faults on
which thunar (xfce4-thunar) was dumping core.  gdb showed the
fault to occur /usr/pkg/lib/libexo.so which was installed from
binary package recently:

-rwxr-xr-x  1 root  wheel  228283 Jun 17 02:57 \
/usr/pkg/lib/libexo-0.3.so.0.5.0

Note "Jun 17"; a previous installation of xfce4 - probably Dec
or Jan - had no such problem.

The machine in question has an AMD k6-3, for which SSE instructions
are not appropriate.  Building with the offending statements
removed from the Makefile allows thunar to run.

If this is not a bug and it has been decided that older hardware
will no longer be supported, then *PLEASE* say so prominently
in documentation and on the NetBSD.org web site.

>How-To-Repeat:
Install recent build of xfce4-thunar on machine with old CPU and run it.

>Fix:
Remove lines 14 through 18 from xfce4-exo Makefile and refrain
from -msse or any such thing in the future.