pkg/39032: net/ntp4 problems

[hasso%estpak.ee@localhost]

>Number:         39032
>Category:       pkg
>Synopsis:       net/ntp4 problems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 24 08:50:00 +0000 2008
>Originator:     Hasso Tepper
>Release:        DragonFly
>Organization:
>Environment:
DragonFly
>Description:
net/ntp4 doesn't compile:

=> Checking file-check results for ntp-4.2.4p4
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkg:
ERROR:         /usr/pkg/share/doc/ntp4/build/hints/dragonfly
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkg/bin/ntptime
ERROR:         /usr/pkg/bin/tickadj
ERROR:         /usr/pkg/share/doc/ntp4/build/hints/netbsd
*** Error code 1

After fixing these PLIST problems (see below) new problem appears:

=> Checking for work-directory references in ntp-4.2.4p4
ERROR: /usr/pkg/bin/ntp-wait:   #! 
/usr/obj/pkgsrc/net/ntp4/work/.tools/bin/perl -w
ERROR: /usr/pkg/bin/ntptrace:   #! 
/usr/obj/pkgsrc/net/ntp4/work/.tools/bin/perl -w
ERROR: *** The above files still have references to the build directory.
ERROR:     This is possibly an error that should be fixed by unwrapping
ERROR:     the files or adding missing tools to the package makefile!
*** Error code 1

>How-To-Repeat:

>Fix:
Regarding PLIST problems two points:

* /usr/pkg/share/doc/ntp4/build/hints/netbsd is installed regardless what OS is 
in use, therefore the change introduced with last update is just wrong and 
should be reverted:

-share/doc/ntp4/build/hints/${LOWER_OPSYS}
+share/doc/ntp4/build/hints/netbsd

* I'm not sure what systems are affected, but ntptime isn't specific to NetBSD 
- at least in DragonFly it is compiled as well, so:

-.if ${OPSYS} == "NetBSD"
+.if ${OPSYS} == "NetBSD" || ${OPSYS} == "DragonFly"
 PLIST.ntptime=         yes

No idea how to fix interpreters.