pkg/38644: games/xfreecell doesn't depend on libX11

[dholland%eecs.harvard.edu@localhost]

>Number:         38644
>Category:       pkg
>Synopsis:       games/xfreecell doesn't depend on libX11
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 13 02:30:01 +0000 2008
>Originator:     David A. Holland <dholland%eecs.harvard.edu@localhost>
>Release:        NetBSD 4.99.59 (pkgsrc 20080512)
>Organization:
>Environment:
System: NetBSD valkyrie 4.99.59 NetBSD 4.99.59 (VALKYRIE) #6: Sat Apr 12 
18:49:29 EDT 2008 root@valkyire:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
Architecture: x86_64
Machine: amd64
>Description:

games/xfreecell links with -lXext -lX11, but only includes libXext's
buildlink3.mk and thus comes out depending only on libXext.

For some reason I haven't investigated, that causes libX11.so to be
buildlinked anyway, even though it's ostensibly only an indirect dep
via libXext. This allows the build to succeed.

>How-To-Repeat:

makefile inspection.

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/games/xfreecell/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- Makefile    24 Mar 2007 19:21:24 -0000      1.14
+++ Makefile    13 May 2008 02:17:34 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.14 2007/03/24 19:21:24 joerg Exp $
 
 DISTNAME=      xfreecell-1.0.5b
-PKGREVISION=   1
+PKGREVISION=   2
 CATEGORIES=    games
 MASTER_SITES=  http://www2.giganet.net/~nakayama/
 EXTRACT_SUFX=  .tgz
@@ -24,4 +24,5 @@
 
 .include "../../x11/libXext/buildlink3.mk"
 .include "../../x11/xextproto/buildlink3.mk"
+.include "../../x11/libX11/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"