pkg/38536: missing files in phppgadmin

[bouyer%lip6.fr@localhost]

>Number:         38536
>Category:       pkg
>Synopsis:       missing files in phppgadmin
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 28 22:35:00 +0000 2008
>Originator:     Manuel Bouyer
>Release:        pkgsrc-2008Q1
>Organization:
http://www.lip6.fr/
>Environment:
System: NetBSD 3.1_STABLE NetBSD 3.1_STABLE (XEN3_DOMU) #23: Sun Sep 2 02:04:47 
CEST 2007 
bouyer@rock:/dsk/l1/misc/bouyer/tmp/i386/obj/dsk/l1/misc/bouyer/netbsd-3/src/sys/arch/i386/compile/XEN3_DOMU
 i386
Architecture: i386
Machine: i386
>Description:
        the phppgadmin package doesn't install 2 javascript files:
        share/phppgadmin/xloadtree/xloadtree2.js
        share/phppgadmin/xloadtree/xtree2.js
        without these files, the navigation frame on the left isn't
        functionnal, and the user interface isn't very friendly without it.
>How-To-Repeat:
        cd pkgsrc/databases/phppgadmin/; make install
        try to use phppgadmin, notice the empty frame on the left.
        notice missing .js files in webserver logs.
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/databases/phppgadmin/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile    30 Jan 2008 10:07:34 -0000      1.22
+++ Makefile    28 Apr 2008 22:27:46 -0000
@@ -67,6 +67,8 @@
                ${DESTDIR}${PHPPGBASE}/libraries/adodb/drivers
        ${INSTALL_DATA} ${WRKSRC}/themes/default/global.css \
                ${DESTDIR}${PHPPGBASE}/themes/default
+       ${INSTALL_DATA} ${WRKSRC}/xloadtree/*.js \
+               ${DESTDIR}${PHPPGBASE}/xloadtree
        ${INSTALL_DATA} ${WRKSRC}/conf/config.inc.php-dist ${DESTDIR}${EGDIR}
        ${INSTALL_DATA} ${WRKDIR}/apache.conf ${DESTDIR}${EGDIR}
 
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/databases/phppgadmin/PLIST,v
retrieving revision 1.10
diff -u -r1.10 PLIST
--- PLIST       30 Jan 2008 10:07:34 -0000      1.10
+++ PLIST       28 Apr 2008 22:27:47 -0000
@@ -292,7 +292,8 @@
 share/phppgadmin/users.php
 share/phppgadmin/viewproperties.php
 share/phppgadmin/views.php
-@exec ${MKDIR} %D/share/phppgadmin/xloadtree
+share/phppgadmin/xloadtree/xloadtree2.js
+share/phppgadmin/xloadtree/xtree2.js
 @dirrm share/phppgadmin/xloadtree
 @dirrm share/phppgadmin/themes/default
 @dirrm share/phppgadmin/themes