pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/38423: url2pkg should use 'make distinfo' (to prevent endless loop)



>Number:         38423
>Category:       pkg
>Synopsis:       url2pkg should use 'make distinfo' (to prevent endless loop)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 13 13:30:00 +0000 2008
>Originator:     Sergey Svishchev
>Release:        4.0
>Organization:
>Environment:
>Description:
If a distfile is not (yet) recorded in distinfo, 'make makesum' no longer 
updates it with new checksums; this makes url2pkg impossible to use.
>How-To-Repeat:

>Fix:
--- pkgtools/url2pkg/files/url2pkg.pl   25 Sep 2007 13:59:42 -0000      1.10
+++ pkgtools/url2pkg/files/url2pkg.pl   13 Apr 2008 09:48:57 -0000
@@ -296,16 +296,13 @@
        print PLIST ("\@comment \$NetBSD\$\n");
        close(PLIST) or die;
 
-       open(DI, ">", "distinfo") or die;
-       close(DI) or die;
-
        open(DESCR, ">", "DESCR") or die;
        close(DESCR) or die;
 
        run_editor("Makefile", 5);
 
-       print ("url2pkg> Running \"make makesum\" ...\n");
-       (system { $make } ($make, "makesum")) == 0 or die;
+       print ("url2pkg> Running \"make distinfo\" ...\n");
+       (system { $make } ($make, "distinfo")) == 0 or die;
        
        print ("url2pkg> Running \"make extract\" ...\n");
        (system { $make } ($make, "extract")) == 0 or die;



Home | Main Index | Thread Index | Old Index