Re: pkg/37634: x11/xproto gcc visibility solaris

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/37634; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/37634: x11/xproto gcc visibility solaris
Date: Sun, 20 Jan 2008 17:03:02 +0100

 On Fri, Dec 28, 2007 at 11:45:01AM +0000, Gilles Dauphin wrote:
 > --- Xfuncproto.h.in.orig        Wed Oct 25 23:45:05 2006
 > +++ Xfuncproto.h.in     Sat Apr  7 01:31:26 2007
 > @@ -85,7 +85,7 @@
 >  # define _X_ATTRIBUTE_PRINTF(x,y)
 >  #endif /* GNUC >= 4 */
 >  
 > -#if defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 303)
 > +#if defined(__GNUC__) && ((__GNUC__ * 100 + __GNUC_MINOR__) >= 303) && 
 > !defined(__sun__)
 >  # define _X_EXPORT      __attribute__((visibility("default")))
 >  # define _X_HIDDEN      __attribute__((visibility("hidden")))
 >  # define _X_INTERNAL    __attribute__((visibility("internal")))
 
 The last update changed the logic a bit. Can you check if the new
 version works better? It enables them only for GCC 4.
 
 Joerg