pkg/37619: glitch in lsof

[dholland%eecs.harvard.edu@localhost]

>Number:         37619
>Category:       pkg
>Synopsis:       glitch in lsof
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 26 14:55:00 +0000 2007
>Originator:     David A. Holland <dholland%eecs.harvard.edu@localhost>
>Release:        NetBSD 2.1.0_STABLE (20071208)
>Organization:
   EECS
>Environment:
System: NetBSD bantha 2.1.0_STABLE NetBSD 2.1.0_STABLE (GENERIC) #3: Fri Dec  1 
14:58:15 EST 2006  root@bantha:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:

"make unpack" in lsof yields, among other things,

   Expected and calculated MD5 signatures don't agree.
   (MD5 (lsof_4.78_src.tar) = b6d823b2ccdf3f9d699e1a4ecaec1eef
   A good source for an MD5 checksum computation tool is the OpenSSL
   You can use the openssl "dgst" operator to compute an MD5 checksum -- != MD5
   (lsof_4.78_src.tar) = b6d823b2ccdf3f9d699e1a4ecaec1eef)

This is because of an overenthusiastic grep.

>How-To-Repeat:

make unpack

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/lsof/Makefile,v
retrieving revision 1.94
diff -u -r1.94 Makefile
--- Makefile    17 Dec 2007 12:15:59 -0000      1.94
+++ Makefile    26 Dec 2007 14:33:10 -0000
@@ -52,7 +52,8 @@
 
 post-extract:
        @(cd ${TMPWRK} ; \
-       EXPMD5=`${GREP} MD5 README.${DISTNAME} | ${SED} 's/^[ ]*//'` ; \
+       EXPMD5=`${GREP} MD5 README.${DISTNAME} | ${GREP} lsof | \
+           ${SED} 's/^[ ]*//'` ; \
        CALCMD5=`${DIGEST} MD5 ${SRCBALL_NAME}.tar` ; \
        if [ "$${EXPMD5}"X != "$${CALCMD5}"X ]; then \
                ${ECHO} "Expected and calculated MD5 signatures don't agree." ; 
\