[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/37489 CVS commit: pkgsrc/mk/pkginstall
The following reply was made to PR pkg/37489; it has been noted by GNATS.
From: Roland Illig <rillig%netbsd.org@localhost>
Subject: PR/37489 CVS commit: pkgsrc/mk/pkginstall
Date: Thu, 6 Dec 2007 22:03:22 +0000 (UTC)
Module Name: pkgsrc
Committed By: rillig
Date: Thu Dec 6 22:03:22 UTC 2007
Print an understandable error message if the number of arguments for
CONF_FILES, CONF_FILES_PERMS, REQD_FILES, REQD_FILES_PERMS is wrong.
NB: The code doesn't read like "shift 5 || error_out" since NetBSD's
shell exits if a shift fails in this case, instead of just reporting an
Fixes PR 37489.
I didn't fix the code in pkglint (which was suggested in the PR) since
it seems too complicated to me. There is no support for a
"MultipleShellWords" data type by now, and pkglint would have to know
that SETUID_ROOT_PERMS is of type "ThreeShellWords: Username, Groupname,
Filemode". That's too much work and doesn't look nicely.
To generate a diff of this commit:
cvs rdiff -r1.36 -r1.37 pkgsrc/mk/pkginstall/bsd.pkginstall.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |