Subject: Re: pkg/36929 (net/tacacs: fails to build with gcc4)
To: None <gnats-bugs@NetBSD.org>
From: Yakovetsky Vladimir <firstname.lastname@example.org>
Date: 09/23/2007 19:14:22
On Sun, Sep 23, 2007 at 08:48:44AM +0000, obache@NetBSD.org wrote:
> Synopsis: net/tacacs: fails to build with gcc4
> State-Changed-From-To: open->feedback
> State-Changed-By: email@example.com
> State-Changed-When: Sun, 23 Sep 2007 08:48:42 +0000
> Simply removing the 'extern' line seems OK.
> Why do you want to keep the line if using gcc<4.0 ?
As forward declarations to static variables are valid gcc<4
that we can keep this line to not change an author's original code
(and a case for gcc4 having preprocessing).
p.s. and really, as in the pkgsrc version of tacacs
forward declaration to nopasswd_str is not used
is possible (I am agree with you) to clean simply this line.