Subject: Re: PR/36777 CVS commit: pkgsrc/devel/binutils
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Yakovetsky Vladimir <yx@rtk0.lneuro.x.ua>
List: pkgsrc-bugs
Date: 08/16/2007 21:05:10
The following reply was made to PR pkg/36777; it has been noted by GNATS.

From: Yakovetsky Vladimir <yx@rtk0.lneuro.x.ua>
To: Roland Illig <rillig@netbsd.org>, gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/36777 CVS commit: pkgsrc/devel/binutils
Date: Fri, 17 Aug 2007 00:04:40 +0300 (EEST)

 In article <20070814092002.C581F63B8EA@narn.NetBSD.org> you wrote:
 > From: Roland Illig <rillig@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Subject: PR/36777 CVS commit: pkgsrc/devel/binutils
 > Date: Tue, 14 Aug 2007 09:08:07 +0000 (UTC)
 > 
 > Module Name:   pkgsrc
 > Committed By:  rillig
 > Date:          Tue Aug 14 09:08:07 UTC 2007
 > 
 > Modified Files:
 >        pkgsrc/devel/binutils: distinfo
 > Added Files:
 >        pkgsrc/devel/binutils/patches: patch-af
 > 
 > Log Message:
 > Fixed a gcc warning reported in PR 36777:
 > read.c:1426: warning: 'stopc' may be used uninitialized in this function
 > 
 	Sorry for incovience, but I shall notice again:
 
 	devel/ and/or cross/binutils with -O3 cflag and with applied patch-af:
 cc -DHAVE_CONFIG_H -I. -I.././gas -I. -D_GNU_SOURCE -I. -I.././gas -I../bfd -I.././gas/config -I.././gas/../include -I.././gas/.. -I.././gas/../bfd -I.././gas/../intl -I../intl -DLOCALEDIR="\"/usr/pkg/share/locale\""    -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -O2 -O3 -march=pentiumpro -mfpmath=sse -msse2 -c read.c
 cc1: warnings being treated as errors
 read.c: In function 's_align':
 read.c:1282: warning: 'stopc' may be used uninitialized in this function
 
 	If you will correct here this failure with patch-ag - you receive its following
 	if you run with -O3 again.
 
 	And so it is a lot of times while you will not correct all binutils code for
 	assembly with -O3 options set (if to tell more precisely - with -finline-functions flag).
 
 	I think that simply it is not necessary to guarantee assembly of
 	a package with -099 optimization flag.
 
 	p.s. package devel/ and cross/binutils is build correctly
 	     without -finline-functions (and without patch-af also).
 
 
 	Sorry for my english.
 
 
 -- 
 Yakovetsky Vladimir