Re: pkg/36769 (Subject: shells/zsh: malformed conditional in Makefile)

[Yakovetsky Vladimir <yx%x.ua@localhost>]

On Mon, Aug 13, 2007 at 07:46:27PM +0000, tron%NetBSD.org@localhost wrote:
> Synopsis: Subject: shells/zsh: malformed conditional in Makefile
> 
> State-Changed-From-To: open->closed
> State-Changed-By: tron%netbsd.org@localhost
> State-Changed-When: Mon, 13 Aug 2007 19:46:26 +0000
> State-Changed-Why:
> I've correct the check without inventing another nested ".if".
> Thanks a lot for the bug report.
> 

  Thanks.


  note:
        if it is necessary to avoid only nested ".if"
        probably to take advantage of _last_ `&& !empty()' defintion:

|>>> diff from previous Makefile.common
 .  if ${OPSYS} == "NetBSD" && ${OBJECT_FMT} == "ELF" && \
-      defined(MKDYNAMICROOT) && !empty(MKDYNAMICROOT:M[Yy][Ee][Ss]) && \
-      exists(${NETBSD_SHLINKER}) && exists(${NETBSD_SHLIBDIR})
+      defined(NETBSD_SHLINKER) && defined(NETBSD_SHLIBDIR) && \
+      defined(MKDYNAMICROOT) && !empty(MKDYNAMICROOT:M[Yy][Ee][Ss])
 #


|>>> diff from current Makefile.common
       defined(OBJECT_FMT) && ${OBJECT_FMT} == "ELF" && \
-      defined(MKDYNAMICROOT) && ${MKDYNAMICROOT} != "no" && \
       defined(NETBSD_SHLINKER) && exists(${NETBSD_SHLINKER}) && \
-      defined(NETBSD_SHLIBDIR) && exists(${NETBSD_SHLIBDIR})
+      defined(NETBSD_SHLIBDIR) && exists(${NETBSD_SHLIBDIR}) && \
+      defined(MKDYNAMICROOT) && !empty(MKDYNAMICROOT:M[Yy][Ee][Ss])
 #



-- 
Yakovetsky Vladimir