Re: pkg/36257 (games/wesnoth has msgfmt problems (plurals) [NetBSD 3.0])

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR pkg/36257; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/36257 (games/wesnoth has msgfmt problems (plurals) [NetBSD 
3.0]) 
Date: Fri, 11 May 2007 01:41:07 +0700

     Date:        Thu, 10 May 2007 15:55:02 +0000 (UTC)
     From:        "OBATA Akio" <obache%NetBSD.org@localhost>
     Message-ID:  <20070510155502.DEF4263B853%narn.NetBSD.org@localhost>
 
   |  No, see above lines in script.  "-e" is never assigned to $pofile.
 
 Yes, it looks as if strings starting with '-' cannot (currently)
 be assigned to pofile (I would still guard against the possibility
 that later changes to the script might alter that - the script does
 not currently use "--" to halt option processing, but someone later
 might add that, which might then allow "-e" as a file name, after the --).
 
 But aside from that, it is possible for pofile to be '(' or other
 stuff like that which can confuse test implementations.
 
 It is so trivial to guard against all of that, that as a rule of thumb,
 I'd simply always protect strings passed to test anywhere it is possible
 to do it.  The cost is close to zero.
 
 kre
 
 ps: please close this PR now - the problem with games/wesnoth is quite
 clearly fixed, it builds just fine.   What is best to have in the script
 is quite a different issue - and changes there are just as likely to have
 an impact on some other package as they are on wesnoth.  The problem that
 affected wesnoth is unlikely to reappear, and if it does, a new PR can
 always be opened.