pkg/36289: icewm tries to unconditionally build in apm support on mac68k

[Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost>]

>Number:         36289
>Category:       pkg
>Synopsis:       icewm tries to unconditionally build in apm support on mac68k
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 07 20:30:00 +0000 2007
>Originator:     Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost>
>Release:        NetBSD 4.0_BETA2
>Organization:
Falling Raindrops
>Environment:
        
        
System: NetBSD fattie 4.0_BETA2 NetBSD 4.0_BETA2 (FATTIE) #0: Fri Apr 20 
18:38:05 CEST 2007 hauke@fattie:/usr/src/sys/arch/mac68k/compile/FATTIE mac68k
Architecture: m68k
Machine: mac68k
>Description:

        A build of wm/icewm as of pkgsrc-2007Q1 (1.2.27, same as on HEAD) 
        on mac68k fails, because it unconditionally compiles in support 
        for APM, which is a peeceish thing. Previous versions didn't do that.


>How-To-Repeat:

        Build icewm on a Lesser Platform like mac68k

[...]
  CXX    objbar.o
  CXX    aapm.o
aapm.cc:44:28: error: machine/apmvar.h: No such file or directory
aapm.cc: In function 'void ApmStr(char*, bool)':
aapm.cc:72: error: aggregate 'apm_power_info ai' has incomplete type and cannot 
be defined
aapm.cc:114: error: 'APM_IOC_GETPOWER' was not declared in this scope
aapm.cc:123: error: 'APM_AC_ON' was not declared in this scope
aapm.cc:124: error: 'APM_BATT_CHARGING' was not declared in this scope

[wrapper.sh] note: The real command line, after the pkgsrc wrapper, was:
/usr/pkgsrc/wm/icewm/work/.gcc/bin/g++ -fno-rtti -O2 
-I/usr/pkgsrc/wm/icewm/work/.buildlink/include 
-I/usr/pkgsrc/wm/icewm/work/.buildlink/include/freetype2 
-I/usr/pkgsrc/wm/icewm/work/.x11-buildlink/include 
-DSTART_PIXMAP=\"bsd-daemon.xpm\" -DHAVE_CONFIG_H 
-DLIBDIR=\"/usr/pkg/share/icewm\" -DCFGDIR=\"/etc/pkg/icewm\" 
-DLOCDIR=\"/usr/pkg/share/locale\" -DKDEDIR=\"\" -DPACKAGE=\"icewm\" 
-DVERSION=\"1.2.27\" "-DHOSTOS=\"NetBSD 4.0_BETA2\"" -DHOSTCPU=\"mac68k\" 
-DEXEEXT=\"\" -DICEWMEXE=\"icewm\" -DICEWMTRAYEXE=\"icewmtray\" 
-DICEWMBGEXE=\"icewmbg\" -DICESMEXE=\"icewm-session\" -DICEHELPEXE=\"icehelp\" 
-DICEHELPIDX=\"/usr/pkg/share/doc/icewm/html/icewm.html\" -DXTHREADS -c aapm.cc 
-L/usr/pkgsrc/wm/icewm/work/.buildlink/lib 
gmake[1]: *** [aapm.o] Error 1
gmake[1]: Leaving directory `/usr/pkgsrc/wm/icewm/work/icewm-1.2.27/src'
gmake: *** [base] Error 2
*** Error code 2

[hauke@pizza] /<3>sys/arch > locate apmvar.h | grep u1/netbsd-4
/u1/netbsd-4/src/sys/arch/hpcarm/include/apmvar.h
/u1/netbsd-4/src/sys/arch/hpcmips/include/apmvar.h
/u1/netbsd-4/src/sys/arch/hpcsh/include/apmvar.h
/u1/netbsd-4/src/sys/arch/i386/include/apmvar.h
/u1/netbsd-4/src/sys/arch/macppc/include/apmvar.h
/u1/netbsd-4/src/sys/arch/sparc/include/apmvar.h
/u1/netbsd-4/src/sys/dev/apm/apmvar.h
/u1/netbsd-4/src/sys/dev/hpc/apm/apmvar.h
/u1/netbsd-4/src/sys/dev/pci/viapmvar.h
[hauke@pizza] /<3>sys/arch >

>Fix:
        The configure script seems to unconditionally use apm support.
        So, either make the NetBSD patch to aapm.h check for the platforms
        that use and support apm, or patch the configure script accordingly.

        Current icewm is at v1.2.30, btw.

>Unformatted: