Re: pkg/36259: sysutils/xentools30 has test == portability problems

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR pkg/36259; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
        pkgsrc-bugs%NetBSD.org@localhost
Subject: Re: pkg/36259: sysutils/xentools30 has test == portability problems
Date: Thu, 3 May 2007 00:02:42 +0200

 On Wed, May 02, 2007 at 07:35:00AM +0000, kre%munnari.OZ.AU@localhost wrote:
 > >Number:         36259
 > >Category:       pkg
 > >Synopsis:       sysutils/xentools30 has test == portability problems
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Wed May 02 07:35:00 +0000 2007
 > >Originator:     Robert Elz
 > >Release:        NetBSD 3.99.15   (pkgsrc current within past 12 hours)
 > >Organization:
 >      Prince of Songkla University
 > >Environment:
 > System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 
 > (GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 
 > kre%jade.coe.psu.ac.th@localhost:/usr/obj/current/kernels/JADE_ASUS i386
 > Architecture: i386
 > Machine: i386
 > >Description:
 >      With PKG_DEVELOPER set (as is the default when using pkg_comp,
 >      which is what I do), pkgsrc checks scripts in packages for
 >      use of (truly idiotic) "test x == y" type commands that are
 >      apaprently becoming common in some mutant universe.
 > 
 >      sysutils/xentools30 is (again) failing that test.
 > 
 >      "Again" as an earlier PR was files against an earlier version
 >      of this package.   The solution at the time was to simply
 >      turn off the tests (the scripts in question, then, not being
 >      used or installed on NetBSD anyway).
 > 
 >      That now looks to have been a mistake - much better to fix the
 >      scripts, and send the fixes back upstream, so the turkeys who
 >      perpetrate this nonsense can learn how test should be used,
 >      and this problem may decrease over time, instead of magnifying.
 
 They certainly don't care as they're developing for linux/bash;
 and I certainly won't spend time fixing scripts that are linux-specific
 anyway. And I'll reject any fix that add more stuff to patches/ than
 necessary.
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --