Subject: Re: pkg/36192: sysutils/apcupsd has a bad rc.d file
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: pkgsrc-bugs
Date: 04/22/2007 16:10:04
The following reply was made to PR pkg/36192; it has been noted by GNATS.
From: Manuel Bouyer <bouyer@antioche.eu.org>
To: Bernd Ernesti <veego@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/36192: sysutils/apcupsd has a bad rc.d file
Date: Sun, 22 Apr 2007 18:08:29 +0200
On Sun, Apr 22, 2007 at 05:59:34PM +0200, Bernd Ernesti wrote:
> On Sun, Apr 22, 2007 at 02:20:01PM +0000, smb@cs.columbia.edu wrote:
> > >Description:
> > The sample rc.d file isn't right for the NetBSD rc.d system.
> > >How-To-Repeat:
> > See above
> > >Fix:
> > Here's the script I'm using, though I suspect that some
> > metavariables need to be used instead, and perhaps a
> > variable config file.
>
> It is mostly ok, there are only some additional lines missing.
>
> See the following patch. There is also the issue that the installed
> apcupsd.master.conf is outdated. I mentioned both problems two months ago
> in a reply to pkg/35594.
>
> Bernd
>
> --- platforms/netbsd/apcupsd.in.orig 2002-05-28 15:34:05.000000000 +0200
> +++ platforms/netbsd/apcupsd.in 2007-01-05 20:52:42.000000000 +0100
> @@ -6,6 +6,10 @@
> # chkconfig: 2345 20 99
> # description: apcupsd monitors power and takes action if necessary
> #
> +# PROVIDE: apcupsd
> +# REQUIRE: DAEMON
> +# KEYWORD: shutdown
> +#
> APCPID=@PIDDIR@/apcupsd.pid
> APCLOCK=@PIDDIR@/apcupsd.lock
> DISTVER="@DISTVER@"
I don't think you want shutdown here. If apcupsd gets killed while running
shutdown, won't it kill shutdown itself ?
--
Manuel Bouyer <bouyer@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--