Subject: pkg/36135: mail/bulk_mailer does not build
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Todd Kover <kovert@omniscient.com>
List: pkgsrc-bugs
Date: 04/10/2007 23:10:00
>Number: 36135
>Category: pkg
>Synopsis: mail/bulk_mailer does not build
>Confidential: no
>Severity: critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Apr 10 23:10:00 +0000 2007
>Originator: Todd Kover
>Release: NetBSD 4.0_BETA2
>Organization:
Omniscient Technologies
>Environment:
System: NetBSD cuendillar.omniscient.com 4.0_BETA2 NetBSD 4.0_BETA2 (GENERIC.MP) #6: Tue Apr 3 15:50:14 EDT 2007 kovert@saidin.omniscient.com:/usr/obj/4.0-stable/i386/omniscient/os/NetBSD-4.0-branch/src/sys/arch/i386/compile/GENERIC.MP i386
Architecture: i386
Machine: i386
>Description:
bulk_mailer prototypes things inconsistantly with the system, and
redefines some system functions
>How-To-Repeat:
cd mail/bulk_maiiler && make
>Fix:
the attached patch fixes it for most modern NetBSDs. Should work for
other modern OS's, too, so long as they have strndup.
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/mail/bulk_mailer/distinfo,v
retrieving revision 1.4
diff -r1.4 distinfo
6c6
< SHA1 (patch-aa) = d4f8142c33df51ea0ede408defa039697a4ec10d
---
> SHA1 (patch-aa) = 3b36891887d555820df58281d9026239671579a8
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/mail/bulk_mailer/patches/patch-aa,v
retrieving revision 1.1
diff -r1.1 patch-aa
3,4c3,4
< --- bulk_mailer.c.orig 2000-05-24 20:34:33.000000000 +0100
< +++ bulk_mailer.c
---
> --- bulk_mailer.c.orig 2000-05-24 19:34:33.000000000 +0000
> +++ bulk_mailer.c 2007-04-10 22:59:33.000000000 +0000
13a14,49
> @@ -122,9 +122,8 @@
> char *strchr();
> char *strrchr();
> #endif
> -char *malloc ();
> -char *realloc ();
> -char *mktemp ();
> +
> +#include <stdlib.h>
>
> /*
> * (default) max different domains per envelope.
> @@ -292,23 +291,6 @@
>
>
> /*
> - * copy the first 'len' characters of a string into malloc'ed
> - * memory, appending a NUL to the copy.
> - */
> -
> -static char *
> -strndup (str, len)
> -char *str;
> -int len;
> -{
> - char *result = malloc_or_else (len + 1);
> -
> - strncpy (result, str, len);
> - result[len] = '\0';
> - return result;
> -}
> -
> -/*
> * sort by case-folded reversed domain
> */
>